[Fuchsia] Add with_envs.py to setup env variables for test-scripts from chromium #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zijiehe-google-com
force-pushed
the
master
branch
from
d019a0d
to
5a10ab6
Compare
zijiehe-google-com
changed the title
There was a problem hiding this comment.
We're in the middle of merging this repo with flutter/engine (see flutter/flutter#67373). Would it be possible to merge this into flutter/engine#49650?
|
That's great; yes, this file can be placed anywhere. |
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Jan 12, 2024
…sts (#49650) This change requires flutter/buildroot#811, and can be executed from buildroot by ``` python3 flutter/tools/fuchsia/with_envs.py flutter/testing/fuchsia/run_tests.py ``` Bug: flutter/flutter#140179 - [V] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [V] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [V] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [V] I listed at least one issue that this PR fixes in the description above. - [V] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [V] I updated/added relevant documentation (doc comments with `///`). - [V] I signed the [CLA]. - [V] All existing and new tests are passing. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
auto-submit bot
added a commit
to flutter/engine
that referenced
this pull request
Jan 12, 2024
…xecute tests" (#49772) Reverts #49650 Initiated by: CaseyHillers This change reverts the following previous change: Original Description: This change requires flutter/buildroot#811, and can be executed from buildroot by ``` python3 flutter/tools/fuchsia/with_envs.py flutter/testing/fuchsia/run_tests.py ``` Bug: flutter/flutter#140179 - [V] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [V] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [V] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [V] I listed at least one issue that this PR fixes in the description above. - [V] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [V] I updated/added relevant documentation (doc comments with `///`). - [V] I signed the [CLA]. - [V] All existing and new tests are passing. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
zanderso
pushed a commit
to flutter/engine
that referenced
this pull request
Jan 19, 2024
…cute tests (#49847) This change is a redo of #49650. https://github.com/zijiehe-google-com/engine/compare/de5c713..main should show the diff between this and the original change. Following paragraph is copied from the original change. This change requires flutter/buildroot#811, and can be executed from buildroot by ``` python3 flutter/tools/fuchsia/with_envs.py flutter/testing/fuchsia/run_tests.py ``` Bug: flutter/flutter#140179 ## Pre-launch Checklist - [V] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [V] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [V] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [V] I listed at least one issue that this PR fixes in the description above. - [V] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [V] I updated/added relevant documentation (doc comments with `///`). - [V] I signed the [CLA]. - [V] All existing and new tests are passing.
auto-submit bot
added a commit
to flutter/engine
that referenced
this pull request
Jan 19, 2024
…s and execute tests" (#49908) Reverts #49847 Initiated by: zanderso This change reverts the following previous change: Original Description: This change is a redo of #49650. https://github.com/zijiehe-google-com/engine/compare/de5c713..main should show the diff between this and the original change. Following paragraph is copied from the original change. This change requires flutter/buildroot#811, and can be executed from buildroot by ``` python3 flutter/tools/fuchsia/with_envs.py flutter/testing/fuchsia/run_tests.py ``` Bug: flutter/flutter#140179 - [V] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [V] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [V] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [V] I listed at least one issue that this PR fixes in the description above. - [V] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [V] I updated/added relevant documentation (doc comments with `///`). - [V] I signed the [CLA]. - [V] All existing and new tests are passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be used by both DEPS and run_tests.py, e.g. flutter/engine#49650.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.