Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fuchsia] Redo - Use chromium test-scripts to download images and execute tests #49940

Merged
merged 7 commits into from
Jan 25, 2024

Conversation

zijiehe-google-com
Copy link
Contributor

@zijiehe-google-com zijiehe-google-com commented Jan 22, 2024

This change is a redo of #49847.

https://github.com/zijiehe-google-com/engine/compare/4530942..main should show the diff between this and the original change; mainly fixes the flutter/flutter#141907.

Following paragraph is copied from the original change.

This change can be executed from buildroot by

python3 flutter/tools/fuchsia/with_envs.py flutter/testing/fuchsia/run_tests.py

Bug: flutter/flutter#140179

  • [V] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [V] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • [V] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • [V] I listed at least one issue that this PR fixes in the description above.
  • [V] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
  • [V] I updated/added relevant documentation (doc comments with ///).
  • [V] I signed the [CLA].
  • [V] All existing and new tests are passing.

@zijiehe-google-com zijiehe-google-com marked this pull request as draft January 22, 2024 19:00
@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

@jrwang jrwang merged commit 7c4ed15 into flutter:main Jan 25, 2024
28 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 25, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 25, 2024
…142221)

flutter/engine@e2014f0...7c4ed15

2024-01-25 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Redo - Use chromium test-scripts to download images and execute tests (flutter/engine#49940)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants