Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts "[Android] Cache GPU resources using HardwareBuffer's id as key" #50114

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

auto-submit[bot]
Copy link
Contributor

@auto-submit auto-submit bot commented Jan 27, 2024

Reverts #50028
Initiated by: jonahwilliams
This change reverts the following previous change:
Original Description:
Once a hardware buffer has been imported (a VkImage created for it), we don't ever need to re-create a VkImage, even when the contents change. The same hardware buffer can be identified by ID. Part of flutter/flutter#142153

Otherwise we spend a lot of time re-creating VkImages:

image

Draft is here, but is currently leaky: #50028
We only need something like a LRU with the max image size (seems to be 3 for me). This does log locally that I'm not calling close correctly:

E/flutter ( 5580): [ERROR:flutter/shell/platform/android/image_external_texture_vk.cc(51)] Size: 3
W/System  ( 5580): A resource failed to call HardwareBuffer.close. 
W/System  ( 5580): A resource failed to call HardwareBuffer.close. 
W/System  ( 5580): A resource failed to call HardwareBuffer.close. 
W/System  ( 5580): A resource failed to call HardwareBuffer.close. 
W/System  ( 5580): A resource failed to call HardwareBuffer.close. 
W/System  ( 5580): A resource failed to call HardwareBuffer.close. 
W/System  ( 5580): A resource failed to call HardwareBuffer.close. 
W/System  ( 5580): A resource failed to call HardwareBuffer.close. 
W/System  ( 5580): A resource failed to call HardwareBuffer.close. 
W/System  ( 5580): A resource failed to call HardwareBuffer.close. 
W/System  ( 5580): A resource failed to call HardwareBuffer.close. 
W/System  ( 5580): A resource failed to call HardwareBuffer.close. 
W/System  ( 5580): A resource failed to call HardwareBuffer.close. 
W/System  ( 5580): A resource failed to call HardwareBuffer.close. 
W/System  ( 5580): A resource failed to call HardwareBuffer.close. 
W/System  ( 5580): A resource failed to call HardwareBuffer.close. 
W/System  ( 5580): A resource failed to call HardwareBuffer.close. 
W/System  ( 5580): A resource failed to call HardwareBuffer.close. 
W/System  ( 5580): A resource failed to call HardwareBuffer.close. 
W/System  ( 5580): A resource failed to call HardwareBuffer.close. 
W/System  ( 5580): A resource failed to call HardwareBuffer.close. 
W/System  ( 5580): A resource failed to call HardwareBuffer.close. 

FYI @johnmccutchan

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Jan 27, 2024
@auto-submit auto-submit bot merged commit 9592be4 into main Jan 27, 2024
5 checks passed
@auto-submit auto-submit bot deleted the revert_bb9a6d131f4be937b945f24014ee69a6dd0522a3 branch January 27, 2024 04:52
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 27, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 27, 2024
…142369)

flutter/engine@2687ddb...95e9a15

2024-01-27 flar@google.com Cache Impeller paths in the DisplayList to amortize conversion (flutter/engine#50076)
2024-01-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Android] Cache GPU resources using HardwareBuffer's id as key" (flutter/engine#50114)
2024-01-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 58665e3dee42 to 7ae508ee09a3 (1 revision) (flutter/engine#50112)
2024-01-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from WHlwlOwznFknNm5IS... to GBTh3gOOgmndwT70X... (flutter/engine#50111)
2024-01-27 skia-flutter-autoroll@skia.org Roll Skia from 6279c88b9e29 to b9b80230c87b (4 revisions) (flutter/engine#50110)
2024-01-27 jonahwilliams@google.com [Impeller] add missing barrier to compute tessellator. (flutter/engine#50108)
2024-01-27 jonahwilliams@google.com [Android] Cache GPU resources using HardwareBuffer's id as key (flutter/engine#50028)
2024-01-27 54558023+keyonghan@users.noreply.github.com Move Mac builder_cache to prod (flutter/engine#50044)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from WHlwlOwznFkn to GBTh3gOOgmnd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-android revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.
Projects
None yet
2 participants