Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github md "Note" and "Tip" blocks in Android shell README #50664

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

gmackall
Copy link
Member

@gmackall gmackall commented Feb 14, 2024

Fixes a couple of misformatted "NOTE" and "TIP" blocks.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gmackall gmackall marked this pull request as ready for review February 14, 2024 20:58
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh silly! Thanks!

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 14, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 14, 2024
Copy link
Contributor

auto-submit bot commented Feb 14, 2024

auto label is removed for flutter/engine/50664, due to - The status or check suite Linux linux_android_emulator_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 14, 2024
@auto-submit auto-submit bot merged commit 52feeed into flutter:main Feb 14, 2024
31 checks passed
sealesj pushed a commit to sealesj/engine that referenced this pull request Feb 15, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 16, 2024
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Feb 16, 2024
2024-02-15 26625149+0xZOne@users.noreply.github.com [Android] Minor refactor: Remove redundant methods. (flutter/engine#50647)
2024-02-15 flar@google.com [Impeller] consolidate transforms in PositionUVWriter (flutter/engine#50635)
2024-02-15 ditman@gmail.com [web] Add dynamic view sizing (v2) (flutter/engine#50271)
2024-02-14 matanlurey@users.noreply.github.com Add useful default options to scenario_app/bin/android_integration_tests.dart (flutter/engine#50667)
2024-02-14 34871572+gmackall@users.noreply.github.com Fix github md "Note" and "Tip" blocks in Android shell README (flutter/engine#50664)
2024-02-14 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run run_with_dart_aot test on fuchsia_profile_x64 (flutter/engine#50613)
2024-02-14 matanlurey@users.noreply.github.com Make all Android scenario_app activities full-screen, even on older Android versions. (flutter/engine#50666)
2024-02-14 skia-flutter-autoroll@skia.org Roll Skia from eae42ea9f7bc to 2d5cf67614d0 (6 revisions) (flutter/engine#50660)
2024-02-14 matanlurey@users.noreply.github.com Add a comment explaining the lifecycle of tls_command_pool_map. (flutter/engine#50623)
2024-02-14 mdebbar@google.com [web] Increase tolerance for golden diffs on Safari (flutter/engine#50655)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 16, 2024
2024-02-15 26625149+0xZOne@users.noreply.github.com [Android] Minor refactor: Remove redundant methods. (flutter/engine#50647)
2024-02-15 flar@google.com [Impeller] consolidate transforms in PositionUVWriter (flutter/engine#50635)
2024-02-15 ditman@gmail.com [web] Add dynamic view sizing (v2) (flutter/engine#50271)
2024-02-14 matanlurey@users.noreply.github.com Add useful default options to scenario_app/bin/android_integration_tests.dart (flutter/engine#50667)
2024-02-14 34871572+gmackall@users.noreply.github.com Fix github md "Note" and "Tip" blocks in Android shell README (flutter/engine#50664)
2024-02-14 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run run_with_dart_aot test on fuchsia_profile_x64 (flutter/engine#50613)
2024-02-14 matanlurey@users.noreply.github.com Make all Android scenario_app activities full-screen, even on older Android versions. (flutter/engine#50666)
2024-02-14 skia-flutter-autoroll@skia.org Roll Skia from eae42ea9f7bc to 2d5cf67614d0 (6 revisions) (flutter/engine#50660)
2024-02-14 matanlurey@users.noreply.github.com Add a comment explaining the lifecycle of tls_command_pool_map. (flutter/engine#50623)
2024-02-14 mdebbar@google.com [web] Increase tolerance for golden diffs on Safari (flutter/engine#50655)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-android
Projects
None yet
2 participants