Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impeller] consolidate transforms in PositionUVWriter #50635

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

flar
Copy link
Contributor

@flar flar commented Feb 14, 2024

Consolidates the 3 coordinate operations in the PositionUVWriter into a single transform for efficiency.

@flar
Copy link
Contributor Author

flar commented Feb 14, 2024

Notable benchmark results, measured locally. Basically, other than the Round cases which currently involve a lot of cubic tessellation overhead, the gains are in the realm of 20-30%.

------------------------------------------------------------------------------------------
Benchmark                                                Current        New       New/Cur
------------------------------------------------------------------------------------------
BM_StrokePolyline/stroke_Cubic_Butt_Bevel_uv             9052 ns      6357 ns      70.2%
BM_StrokePolyline/stroke_Cubic_Butt_Miter_uv             8972 ns      7522 ns      83.8%
BM_StrokePolyline/stroke_Cubic_Butt_Round_uv            18183 ns     17550 ns      96.5%
BM_StrokePolyline/stroke_Cubic_Square_Bevel_uv           9103 ns      6521 ns      71.6%
BM_StrokePolyline/stroke_Cubic_Round_Bevel_uv            9175 ns      6378 ns      69.5%
BM_StrokePolyline/stroke_Quadratic_Butt_Bevel_uv         9015 ns      6382 ns      70.8%
BM_StrokePolyline/stroke_Quadratic_Butt_Miter_uv         8610 ns      7212 ns      83.8%
BM_StrokePolyline/stroke_Quadratic_Butt_Round_uv        17958 ns     17601 ns      98.0%
BM_StrokePolyline/stroke_Quadratic_Square_Bevel_uv       8922 ns      6252 ns      70.1%
BM_StrokePolyline/stroke_Quadratic_Round_Bevel_uv        8859 ns      6353 ns      71.7%
BM_StrokePolyline/stroke_RRect_Butt_Bevel_uv             1419 ns      1093 ns      77.0%

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #50635 at sha 8891105

@flar
Copy link
Contributor Author

flar commented Feb 14, 2024

The golden failure notice is stale, fixed by the second commit...

@flar flar added autosubmit Merge PR when tree becomes green via auto submit App and removed will affect goldens labels Feb 15, 2024
@auto-submit auto-submit bot merged commit 7f3b96a into flutter:main Feb 15, 2024
29 checks passed
sealesj pushed a commit to sealesj/engine that referenced this pull request Feb 15, 2024
Consolidates the 3 coordinate operations in the PositionUVWriter into a single transform for efficiency.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 16, 2024
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Feb 16, 2024
2024-02-15 26625149+0xZOne@users.noreply.github.com [Android] Minor refactor: Remove redundant methods. (flutter/engine#50647)
2024-02-15 flar@google.com [Impeller] consolidate transforms in PositionUVWriter (flutter/engine#50635)
2024-02-15 ditman@gmail.com [web] Add dynamic view sizing (v2) (flutter/engine#50271)
2024-02-14 matanlurey@users.noreply.github.com Add useful default options to scenario_app/bin/android_integration_tests.dart (flutter/engine#50667)
2024-02-14 34871572+gmackall@users.noreply.github.com Fix github md "Note" and "Tip" blocks in Android shell README (flutter/engine#50664)
2024-02-14 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run run_with_dart_aot test on fuchsia_profile_x64 (flutter/engine#50613)
2024-02-14 matanlurey@users.noreply.github.com Make all Android scenario_app activities full-screen, even on older Android versions. (flutter/engine#50666)
2024-02-14 skia-flutter-autoroll@skia.org Roll Skia from eae42ea9f7bc to 2d5cf67614d0 (6 revisions) (flutter/engine#50660)
2024-02-14 matanlurey@users.noreply.github.com Add a comment explaining the lifecycle of tls_command_pool_map. (flutter/engine#50623)
2024-02-14 mdebbar@google.com [web] Increase tolerance for golden diffs on Safari (flutter/engine#50655)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 16, 2024
2024-02-15 26625149+0xZOne@users.noreply.github.com [Android] Minor refactor: Remove redundant methods. (flutter/engine#50647)
2024-02-15 flar@google.com [Impeller] consolidate transforms in PositionUVWriter (flutter/engine#50635)
2024-02-15 ditman@gmail.com [web] Add dynamic view sizing (v2) (flutter/engine#50271)
2024-02-14 matanlurey@users.noreply.github.com Add useful default options to scenario_app/bin/android_integration_tests.dart (flutter/engine#50667)
2024-02-14 34871572+gmackall@users.noreply.github.com Fix github md "Note" and "Tip" blocks in Android shell README (flutter/engine#50664)
2024-02-14 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run run_with_dart_aot test on fuchsia_profile_x64 (flutter/engine#50613)
2024-02-14 matanlurey@users.noreply.github.com Make all Android scenario_app activities full-screen, even on older Android versions. (flutter/engine#50666)
2024-02-14 skia-flutter-autoroll@skia.org Roll Skia from eae42ea9f7bc to 2d5cf67614d0 (6 revisions) (flutter/engine#50660)
2024-02-14 matanlurey@users.noreply.github.com Add a comment explaining the lifecycle of tls_command_pool_map. (flutter/engine#50623)
2024-02-14 mdebbar@google.com [web] Increase tolerance for golden diffs on Safari (flutter/engine#50655)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
None yet
2 participants