Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Remove the unnecessary parent interface. #50677

Merged
merged 1 commit into from
Feb 15, 2024
Merged

[Android] Remove the unnecessary parent interface. #50677

merged 1 commit into from
Feb 15, 2024

Conversation

0xZOne
Copy link
Member

@0xZOne 0xZOne commented Feb 15, 2024 •
edited
Loading

ImageConsumer and GLTextureConsumer should not inherit from TextureEntry.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@chinmaygarde
Copy link
Member

This looks right to me but @johnmccutchan should probably also take a look.

@0xZOne 0xZOne added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 15, 2024
@auto-submit auto-submit bot merged commit fa1d168 into flutter:main Feb 15, 2024
28 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
fa1d168e4 [Android] Remove the unnecessary parent interface. (flutter…
a22ed4b 
…/engine#50677)
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Feb 16, 2024
@jason-simmons
Manual roll Flutter Engine from b7103bc8b374 to 7de84271eb65
8c884f7 
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from a8e4db1afac5 to 078b316e0563 (4 revisions) (flutter/engine#50700)
2024-02-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 5e442dc80903 to 9bbac4d40725 (2 revisions) (flutter/engine#50699)
2024-02-15 26625149+0xZOne@users.noreply.github.com [Android] Remove the unnecessary parent interface. (flutter/engine#50677)
2024-02-15 bdero@google.com [Impeller] Add an error message when failing to write golden screenshot. (flutter/engine#50698)
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 6ee2b5f61ae5 to a8e4db1afac5 (5 revisions) (flutter/engine#50696)
2024-02-15 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts (flutter/engine#50657)
2024-02-15 30870216+gaaclarke@users.noreply.github.com [Impeller] Updated benchmarks (flutter/engine#50694)
2024-02-15 godofredoc@google.com Documentation for test timeouts. (flutter/engine#50687)
2024-02-15 zanderso@users.noreply.github.com Shift some Linux builders from Goma to RBE (flutter/engine#50653)
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 12d0b7fac4c3 to 6ee2b5f61ae5 (1 revision) (flutter/engine#50691)
@jason-simmons jason-simmons mentioned this pull request Feb 16, 2024
Merged
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 16, 2024
@jason-simmons
Manual roll Flutter Engine from b7103bc8b374 to 7de84271eb65 (#143564)
6f6950b 
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from a8e4db1afac5 to 078b316e0563 (4 revisions) (flutter/engine#50700)
2024-02-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 5e442dc80903 to 9bbac4d40725 (2 revisions) (flutter/engine#50699)
2024-02-15 26625149+0xZOne@users.noreply.github.com [Android] Remove the unnecessary parent interface. (flutter/engine#50677)
2024-02-15 bdero@google.com [Impeller] Add an error message when failing to write golden screenshot. (flutter/engine#50698)
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 6ee2b5f61ae5 to a8e4db1afac5 (5 revisions) (flutter/engine#50696)
2024-02-15 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts (flutter/engine#50657) 2024-02-15 30870216+gaaclarke@users.noreply.github.com [Impeller] Updated benchmarks (flutter/engine#50694)
2024-02-15 godofredoc@google.com Documentation for test timeouts. (flutter/engine#50687)
2024-02-15 zanderso@users.noreply.github.com Shift some Linux builders from Goma to RBE (flutter/engine#50653)
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 12d0b7fac4c3 to 6ee2b5f61ae5 (1 revision) (flutter/engine#50691)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
fa1d168e4 [Android] Remove the unnecessary parent interface. (flutter…
cb35c75 
…/engine#50677)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
Roll Flutter Engine from b7103bc8b374 to dd530f1556df (17 revisions) (#…
6ee7e24 
…143565)

flutter/engine@b7103bc...dd530f1

2024-02-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 9bbac4d40725 to 947c8c487e28 (1 revision) (flutter/engine#50709)
2024-02-16 skia-flutter-autoroll@skia.org Roll Skia from 3cbb5d6a71fe to c89a4cd72308 (2 revisions) (flutter/engine#50708)
2024-02-16 737941+loic-sharma@users.noreply.github.com [Windows] Improve `FlutterWindow` unit tests (flutter/engine#50676)
2024-02-16 zanderso@users.noreply.github.com [et] Adds a logger (flutter/engine#50693)
2024-02-15 matanlurey@users.noreply.github.com Update README.md (flutter/engine#50702)
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 078b316e0563 to 3cbb5d6a71fe (2 revisions) (flutter/engine#50704)
2024-02-15 tugorez@users.noreply.github.com Move the accesibility placeholder to the platform dispatcher. (flutter/engine#50608)
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from a8e4db1afac5 to 078b316e0563 (4 revisions) (flutter/engine#50700)
2024-02-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 5e442dc80903 to 9bbac4d40725 (2 revisions) (flutter/engine#50699)
2024-02-15 26625149+0xZOne@users.noreply.github.com [Android] Remove the unnecessary parent interface. (flutter/engine#50677)
2024-02-15 bdero@google.com [Impeller] Add an error message when failing to write golden screenshot. (flutter/engine#50698)
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 6ee2b5f61ae5 to a8e4db1afac5 (5 revisions) (flutter/engine#50696)
2024-02-15 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts (flutter/engine#50657)
2024-02-15 30870216+gaaclarke@users.noreply.github.com [Impeller] Updated benchmarks (flutter/engine#50694)
2024-02-15 godofredoc@google.com Documentation for test timeouts. (flutter/engine#50687)
2024-02-15 zanderso@users.noreply.github.com Shift some Linux builders from Goma to RBE (flutter/engine#50653)
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 12d0b7fac4c3 to 6ee2b5f61ae5 (1 revision) (flutter/engine#50691)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@0xZOne 0xZOne deleted the task/refactoring branch February 22, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnmccutchan johnmccutchan johnmccutchan approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-android
Projects
None yet
Milestone
No milestone
3 participants
@0xZOne @chinmaygarde @johnmccutchan