Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift some Linux builders from Goma to RBE #50653

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

zanderso
Copy link
Member

@zanderso zanderso commented Feb 14, 2024

This PR shifts all Linux builders except for linux_fuchsia and linux_clang_tidy from GOMA to RBE. It also shifts one build from another builder to linux_unopt.

@zanderso zanderso force-pushed the more-rbe-linux branch 2 times, most recently from 49cbb7e to fa3e66d Compare February 14, 2024 20:39
@zanderso zanderso changed the title Shift Linux builders from Goma to RBE Shift some Linux builders from Goma to RBE Feb 15, 2024
@keyonghan
Copy link
Contributor

This PR shifts all Linux builders except for linux_fuchsia and linux_clang_tidy from GOMA to RBE. It also shifts one build from another builder to linux_unopt.

Any reason to skip these two builders?

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso
Copy link
Member Author

Any reason to skip these two builders?

The clang tidy scripts don't understand the rewrapper prefix on the compilation commands and will need some more work.

In the Fuchsia builds, either clang or rewrapper processes were getting killed without dropping any logs, and will need more investigation.

@zanderso zanderso merged commit e15947b into flutter:main Feb 15, 2024
27 checks passed
@zanderso zanderso deleted the more-rbe-linux branch February 15, 2024 18:42
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 16, 2024
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Feb 16, 2024
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from a8e4db1afac5 to 078b316e0563 (4 revisions) (flutter/engine#50700)
2024-02-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 5e442dc80903 to 9bbac4d40725 (2 revisions) (flutter/engine#50699)
2024-02-15 26625149+0xZOne@users.noreply.github.com [Android] Remove the unnecessary parent interface. (flutter/engine#50677)
2024-02-15 bdero@google.com [Impeller] Add an error message when failing to write golden screenshot. (flutter/engine#50698)
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 6ee2b5f61ae5 to a8e4db1afac5 (5 revisions) (flutter/engine#50696)
2024-02-15 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts (flutter/engine#50657)
2024-02-15 30870216+gaaclarke@users.noreply.github.com [Impeller] Updated benchmarks (flutter/engine#50694)
2024-02-15 godofredoc@google.com Documentation for test timeouts. (flutter/engine#50687)
2024-02-15 zanderso@users.noreply.github.com Shift some Linux builders from Goma to RBE (flutter/engine#50653)
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 12d0b7fac4c3 to 6ee2b5f61ae5 (1 revision) (flutter/engine#50691)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 16, 2024
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from a8e4db1afac5 to 078b316e0563 (4 revisions) (flutter/engine#50700)
2024-02-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 5e442dc80903 to 9bbac4d40725 (2 revisions) (flutter/engine#50699)
2024-02-15 26625149+0xZOne@users.noreply.github.com [Android] Remove the unnecessary parent interface. (flutter/engine#50677)
2024-02-15 bdero@google.com [Impeller] Add an error message when failing to write golden screenshot. (flutter/engine#50698)
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 6ee2b5f61ae5 to a8e4db1afac5 (5 revisions) (flutter/engine#50696)
2024-02-15 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts (flutter/engine#50657) 2024-02-15 30870216+gaaclarke@users.noreply.github.com [Impeller] Updated benchmarks (flutter/engine#50694)
2024-02-15 godofredoc@google.com Documentation for test timeouts. (flutter/engine#50687)
2024-02-15 zanderso@users.noreply.github.com Shift some Linux builders from Goma to RBE (flutter/engine#50653)
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 12d0b7fac4c3 to 6ee2b5f61ae5 (1 revision) (flutter/engine#50691)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 16, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 16, 2024
…143565)

flutter/engine@b7103bc...dd530f1

2024-02-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 9bbac4d40725 to 947c8c487e28 (1 revision) (flutter/engine#50709)
2024-02-16 skia-flutter-autoroll@skia.org Roll Skia from 3cbb5d6a71fe to c89a4cd72308 (2 revisions) (flutter/engine#50708)
2024-02-16 737941+loic-sharma@users.noreply.github.com [Windows] Improve `FlutterWindow` unit tests (flutter/engine#50676)
2024-02-16 zanderso@users.noreply.github.com [et] Adds a logger (flutter/engine#50693)
2024-02-15 matanlurey@users.noreply.github.com Update README.md (flutter/engine#50702)
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 078b316e0563 to 3cbb5d6a71fe (2 revisions) (flutter/engine#50704)
2024-02-15 tugorez@users.noreply.github.com Move the accesibility placeholder to the platform dispatcher. (flutter/engine#50608)
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from a8e4db1afac5 to 078b316e0563 (4 revisions) (flutter/engine#50700)
2024-02-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 5e442dc80903 to 9bbac4d40725 (2 revisions) (flutter/engine#50699)
2024-02-15 26625149+0xZOne@users.noreply.github.com [Android] Remove the unnecessary parent interface. (flutter/engine#50677)
2024-02-15 bdero@google.com [Impeller] Add an error message when failing to write golden screenshot. (flutter/engine#50698)
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 6ee2b5f61ae5 to a8e4db1afac5 (5 revisions) (flutter/engine#50696)
2024-02-15 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts (flutter/engine#50657)
2024-02-15 30870216+gaaclarke@users.noreply.github.com [Impeller] Updated benchmarks (flutter/engine#50694)
2024-02-15 godofredoc@google.com Documentation for test timeouts. (flutter/engine#50687)
2024-02-15 zanderso@users.noreply.github.com Shift some Linux builders from Goma to RBE (flutter/engine#50653)
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 12d0b7fac4c3 to 6ee2b5f61ae5 (1 revision) (flutter/engine#50691)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants