Temporarily disable goldens for Safari. #50724
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
eyebrowsoffire
added
the
autosubmit
|
auto label is removed for flutter/engine/50724, due to - The status or check suite Linux mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
eyebrowsoffire
added
the
autosubmit
…143609) flutter/engine@13dc857...2eed3fb 2024-02-16 jacksongardner@google.com Temporarily disable goldens for Safari. (flutter/engine#50724) 2024-02-16 kustermann@google.com [web] Remove unused `allowInterop` usage in flutter web code (flutter/engine#50718) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Safari is producing too many golden diffs. See flutter/flutter#143591. This disables them for now to stop the noise, but we should look into a longer term solution.