[Impeller] Add GeometryResult enum with StC modes. #50816
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Also adds missing enum defaults which were dangerously missing. |
bdero
force-pushed
the
bdero/stc-modes
branch
from
7b3c4ff
to
331bb9c
Compare
|
I love how c++ is actively trying to murder us |
…143827) flutter/engine@93063f6...e16f43e 2024-02-21 bdero@google.com [Impeller] Add GeometryResult enum with StC modes. (flutter/engine#50816) 2024-02-21 bdero@google.com Update impeller-cmake-example (flutter/engine#50808) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Replace
prevent_overdrawwith an enum that also containing the two StC cases.