[Fuchsia] Use shared gn-sdk from chromium #50855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Feb 23, 2024
This change imports some missing features from https://github.com/flutter/engine/tree/main/tools/fuchsia/gn-sdk so that flutter can use the same gn-sdk rather than maintaining a different copy. Note, the gn-sdk in flutter does not support idk version which can be addressed by flutter/engine#50855 and its follow-up changes. Beside the missing features, it also improves the compatibility of the gn-sdk to 1) allow customized gn_configs.gni instead of a hard-coded location. 2) handle several edge cases, like duplicated 'meta/' or '.cml', and missing folders. The change itself should be transparent to chromium, newly added features won't be enabled without explicitly using the relevant parameters or gn arguments. Bug: flutter/flutter#140179 Change-Id: I5b27f286de5abd877ce81404759b179a2743b426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5315612 Reviewed-by: David Song <wintermelons@google.com> Commit-Queue: Zijie He <zijiehe@google.com> Cr-Commit-Position: refs/heads/main@{#1264668}
This reverts commit 43cb29e.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zijiehe-google-com
added
the
autosubmit
zijiehe-google-com
removed
the
autosubmit
zijiehe-google-com
added
the
autosubmit
zanderso
added a commit
to flutter/flutter
that referenced
this pull request
Feb 28, 2024
5e0d9ba35d Roll Skia from 636e136b0da9 to 1beae57ea0dd (3 revisions) (flutter/engine#51007) 63b6117514 [skwasm] Clip pictures if they go beyond the bounds of the window. (flutter/engine#50887) cd57dc9b4c GLES for scenario_app tests using Impeller (flutter/engine#51000) ef4c205239 Roll Skia from d5ca52bc7739 to 636e136b0da9 (8 revisions) (flutter/engine#51006) 8b240244ef [Fuchsia] Use shared gn-sdk from chromium (flutter/engine#50855)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuchsia team is working on getting rid of non-versioned libraries and sysroot (see b/40935282), but flutter is using a fairly old version of in-house gn-sdk. It's hard to maintain it anymore.
So this change removes the in-house gn-sdk and replaces it with the gn-sdk from chromium.
This is a prerequisite to select the idk / sdk lib version according to the api-level.
This change contains three parts:
Bug: b/40935282
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.