[skwasm] Clip pictures if they go beyond the bounds of the window. #50887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
harryterkelsen
approved these changes
Feb 27, 2024
eyebrowsoffire
added
the
autosubmit
zanderso
added a commit
to flutter/flutter
that referenced
this pull request
Feb 28, 2024
5e0d9ba35d Roll Skia from 636e136b0da9 to 1beae57ea0dd (3 revisions) (flutter/engine#51007) 63b6117514 [skwasm] Clip pictures if they go beyond the bounds of the window. (flutter/engine#50887) cd57dc9b4c GLES for scenario_app tests using Impeller (flutter/engine#51000) ef4c205239 Roll Skia from d5ca52bc7739 to 636e136b0da9 (8 revisions) (flutter/engine#51006) 8b240244ef [Fuchsia] Use shared gn-sdk from chromium (flutter/engine#50855)
|
I think this is causing the skwasm benchmarks to flake. See https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Linux%20web_benchmarks_skwasm I'm going to revert this for now. |
eyebrowsoffire
added
the
revert
|
Time to revert pull request flutter/engine/50887 has elapsed. |
auto-submit
bot
removed
the
revert
eyebrowsoffire
added a commit
to eyebrowsoffire/engine
that referenced
this pull request
Feb 28, 2024
…ndow. (flutter#50887)" This reverts commit 63b6117. The change is causing skwasm benchmarks to flake.
|
Manual revert here: #51067 |
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
…ndow. (#50887)" (#51067) This reverts commit 63b6117. The change is causing skwasm benchmarks to flake. See https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Linux%20web_benchmarks_skwasm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes flutter/flutter#143800, where we are attempting to capture an image that is way too large. We only need to render the part of the image that will be visible in the window.