Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts "Reland 3: Multiview pipeline (#49950)" #50929

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

auto-submit[bot]
Copy link
Contributor

@auto-submit auto-submit bot commented Feb 23, 2024

Reverts #49950

Initiated by: dkwingsmt

Reason for reverting: Head redness

java.lang.RuntimeException: Timeout waiting for firstFrameLatch to signal
	at dev.flutter.scenarios.ExternalTextureFlutterActivity.waitUntilFlutterRendered(ExternalTextureFlutterActivity.java:98)
	at dev.flutter.scenariosui.ScreenshotUtil.capture(ScreenshotUtil.java:122)

Original PR Author: dkwingsmt

Reviewed By: {loic-sharma}

This change reverts the following previous change:
Original Description:
This is the 3rd attempt to land multiview pipeline, following #47239.

The pipeline now properly implements the required logic for scheduleWarmUpFrame to work in a multi-view setup, following the preparation in flutter/flutter#143290 and #50570.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Feb 23, 2024
@dkwingsmt dkwingsmt closed this Feb 23, 2024
@dkwingsmt
Copy link
Contributor

Let's pause the revert and wait for a little longer.

@dkwingsmt dkwingsmt reopened this Feb 23, 2024
@dkwingsmt dkwingsmt merged commit ca24520 into main Feb 23, 2024
7 of 8 checks passed
@dkwingsmt dkwingsmt deleted the revert_9409b75e8f35c53e6937a8e7e98b101372a95096 branch February 23, 2024 23:15
dkwingsmt added a commit to dkwingsmt/engine that referenced this pull request Feb 23, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 24, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 24, 2024
…144068)

flutter/engine@9409b75...ca24520

2024-02-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland 3: Multiview pipeline  (#49950)" (flutter/engine#50929)
2024-02-23 dnfield@google.com Remove timeouts from CountdownLatch.await in tests (flutter/engine#50930)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.
Projects
None yet
2 participants