Improve, test, and fix a bug related to adb logcat filtering.
#51012
Conversation
| static const Set<String> kKnownNoiseTags = <String>{ | ||
| 'MonitoringInstr', | ||
| 'ResourceExtractor', | ||
| 'THREAD_STATE', |
There was a problem hiding this comment.
nit: Is this really a noise tag? This gets dumped if a test hangs and tells you what the threads are doing right? Is it used otherwise.
There was a problem hiding this comment.
👍🏼 I moved this from kKnownNoise to kKnownUsefulError.
|
|
||
| void main() { | ||
| /// Simulates the filtering of logcat output [lines]. | ||
| Iterable<String> filter(Iterable<String> lines, {int? filterProcessId}) { |
There was a problem hiding this comment.
nit: does this really belong in its own testable class? Right now this looks like it's roughly copied from the run_android_test.dart
There was a problem hiding this comment.
I'll file a follow-up issue, as it really depends on how much more work I'm going to do on the CLI:
flutter/flutter#144252
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
64a375de9c [Windows] Make the engine own a map of views (flutter/engine#51017) 73480bf11d Rename some classes in the engine_build_configs package (flutter/engine#51016) 2756f14a46 Remove rewrapper prefix from compiler commands for clang-tidy (flutter/engine#51001) 0f727a5b31 Improve, test, and fix a bug related to `adb logcat` filtering. (flutter/engine#51012) ab4d6db3f1 Move vulkan-deps to //flutter/third_party/vulkan-deps (flutter/engine#51013)
Write tests for the
AdbLogLineextension/parsing, and run it on CI.Fixes Add a test of the ADB log parsing flutter#144164.
Improve the logging to include
androidemu-related errors logsWork towards Add a test of the ADB log parsing flutter#144164.
Clarified logic/fixed a bug related to handling
filterProcessId: ...