[Impeller] implements blur styles for gradients #51264
Conversation
| @@ -408,7 +408,7 @@ class ContentContext { | |||
| /// | |||
| // TODO(bdero): Remove this setting once StC is fully de-risked | |||
| // https://github.com/flutter/flutter/issues/123671 | |||
| static constexpr bool kEnableStencilThenCover = true; | |||
| static constexpr bool kEnableStencilThenCover = false; | |||
There was a problem hiding this comment.
@bdero this only works if I turn stencil and cover off (of course inner and outer are reversed though)
impeller/entity/contents/filters/gaussian_blur_filter_contents.cc
Outdated
Show resolved
Hide resolved
gaaclarke
force-pushed
the
blur-mask-gradients
branch
from
7eb5d3a
to
8a60785
Compare
gaaclarke
force-pushed
the
blur-mask-gradients
branch
from
20b9f4b
to
391d967
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Golden file changes are available for triage from new commit, Click here to view. |
|
Golden file changes are available for triage from new commit, Click here to view. |
|
(Looks like |
gaaclarke
added
the
autosubmit
|
|
There is an open issue about the gaussian blur not working on opengles. We've deprioritized opengles work though. |
…ions) (#145006) Manual roll requested by zra@google.com flutter/engine@6771307...af1fd17 2024-03-12 34871572+gmackall@users.noreply.github.com Try making android scenario app not do animations (flutter/engine#51349) 2024-03-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 7a2c94fd0a26 to c97f2b303259 (1 revision) (flutter/engine#51345) 2024-03-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from L6_XzizcJqjneCvGA... to UR-nKoLidl7cVLrrN... (flutter/engine#51344) 2024-03-12 30870216+gaaclarke@users.noreply.github.com [Impeller] implements blur styles for gradients (flutter/engine#51264) 2024-03-11 xilaizhang@google.com [codesign] fix typo in binary path (flutter/engine#51339) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from L6_XzizcJqjn to UR-nKoLidl7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
fixes flutter/flutter#144449
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.