Try making android scenario app not do animations #51349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this fully skips animations, it doesn't just tweak speed. In particular, see the rotation test at around 33 seconds in. |
matanlurey
approved these changes
Mar 12, 2024
gmackall
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 12, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 12, 2024
…ions) (#145006) Manual roll requested by zra@google.com flutter/engine@6771307...af1fd17 2024-03-12 34871572+gmackall@users.noreply.github.com Try making android scenario app not do animations (flutter/engine#51349) 2024-03-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 7a2c94fd0a26 to c97f2b303259 (1 revision) (flutter/engine#51345) 2024-03-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from L6_XzizcJqjneCvGA... to UR-nKoLidl7cVLrrN... (flutter/engine#51344) 2024-03-12 30870216+gaaclarke@users.noreply.github.com [Impeller] implements blur styles for gradients (flutter/engine#51264) 2024-03-11 xilaizhang@google.com [codesign] fix typo in binary path (flutter/engine#51339) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from L6_XzizcJqjn to UR-nKoLidl7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skips animations
Looks like this, for reference:
no_animation_example.webm
(This is the animation from #51329, so note that the first test looks weird because I lagged my emulator by alt tabbing).
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.