Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP] revert round out of entity pass bounds. #51425

Conversation

jonahwilliams
Copy link
Member

Cherry pick revert of #51395

@jonahwilliams jonahwilliams changed the title [Impeller] revert round out of entity pass bounds. [CP] revert round out of entity pass bounds. Mar 15, 2024
@XilaiZhang
Copy link
Contributor

XilaiZhang commented Mar 19, 2024

Friendly ping, can we tune the failed test and merge this PR before the release cutoff time? Thank you!

triggering a rerun on the failed test

@XilaiZhang
Copy link
Contributor

tests all passed, still needs a lgtm to merge. I will stamp this to unblock since it has been pre-approved by Chinmay

Copy link
Contributor

@XilaiZhang XilaiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamping to unblock since this was pre approved in flutter/flutter#145177

@XilaiZhang XilaiZhang added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 19, 2024
@auto-submit auto-submit bot merged commit 8e74552 into flutter:flutter-3.19-candidate.1 Mar 19, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
None yet
2 participants