-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add android_debug_unopt_arm64
to local_engine.json
.
#51427
Conversation
@@ -19,6 +19,26 @@ | |||
"targets": [] | |||
} | |||
}, | |||
{ | |||
"drone_dimensions": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope to get the builds in this file running on CI soon, so wondering if local workflows will need both the unopt and non-unopt version of android_debug_arm64?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We talked offline, local builds will probably all be unopt
(the other configurations will be covered by release builders), so I am going to remove android_debug_arm64
(/cc @johnmccutchan) from this file, and then continue to chat with John about "what should we do for duplicate names in general".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only use android_debug_arm64 and never the unopt variant. So please don't remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only use android_debug_arm64 and never the unopt variant. So please don't remove it.
Ack. Can I clarify though, why is this builder not sufficient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chatted offline, because that builder doesn't run/allow macos
. Reverted that -
block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break my workflow
…145221) flutter/engine@1e199ce...76f33eb 2024-03-15 skia-flutter-autoroll@skia.org Roll Skia from 52bb1539c5cf to 54ecc23acf31 (11 revisions) (flutter/engine#51438) 2024-03-15 matanlurey@users.noreply.github.com Add `android_debug_unopt_arm64` to `local_engine.json`. (flutter/engine#51427) 2024-03-15 matanlurey@users.noreply.github.com Remove the Android-drawn surface rendering from scenario_app. (flutter/engine#51433) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
As written:
Yay!