Manual Dart roll to 0ac840ba1 and update frontend server snapshot filename #51921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ename The Dart SDK is now only building an AOT snapshot for the frontend server (see https://dart-review.googlesource.com/c/sdk/+/359100)
|
cc @a-siva |
zanderso
approved these changes
Apr 4, 2024
jason-simmons
added
the
autosubmit
|
adding @derekxu16 to this PR as he was trying to land a similar PR |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 5, 2024
|
Reason for revert: This Dart roll is blocking the roll of the engine to the framework. Unblocking the rolls depends on addressing flutter/flutter#146164. |
zanderso
added
the
revert
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Apr 5, 2024
…pshot filename (#51921)" (#51927) Reverts: #51921 Initiated by: zanderso Reason for reverting: This Dart roll is blocking the roll of the engine to the framework. Unblocking the rolls depends on addressing flutter/flutter#146164. Original PR Author: jason-simmons Reviewed By: {zanderso, jonahwilliams} This change reverts the following previous change: The Dart SDK is now only building an AOT snapshot for the frontend server (see https://dart-review.googlesource.com/c/sdk/+/359100)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 5, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 5, 2024
…146322) flutter/engine@d44462a...f17d586 2024-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual Dart roll to 0ac840ba1 and update frontend server snapshot filename (#51921)" (flutter/engine#51927) 2024-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 0ac840ba1f0b to 31ddd6924103 (5 revisions) (#51924)" (flutter/engine#51926) 2024-04-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 0ac840ba1f0b to 31ddd6924103 (5 revisions) (flutter/engine#51924) 2024-04-04 jason-simmons@users.noreply.github.com Manual Dart roll to 0ac840ba1 and update frontend server snapshot filename (flutter/engine#51921) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#146322) flutter/engine@d44462a...f17d586 2024-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual Dart roll to 0ac840ba1 and update frontend server snapshot filename (flutter#51921)" (flutter/engine#51927) 2024-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 0ac840ba1f0b to 31ddd6924103 (5 revisions) (flutter#51924)" (flutter/engine#51926) 2024-04-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 0ac840ba1f0b to 31ddd6924103 (5 revisions) (flutter/engine#51924) 2024-04-04 jason-simmons@users.noreply.github.com Manual Dart roll to 0ac840ba1 and update frontend server snapshot filename (flutter/engine#51921) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dart SDK is now only building an AOT snapshot for the frontend server (see https://dart-review.googlesource.com/c/sdk/+/359100)