Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll Clang to b1d2e8510b58893e58558ffdf3f8ba29c1e25e5a #52062

Closed
wants to merge 1 commit into from

Conversation

zanderso
Copy link
Member

No description provided.

@zanderso
Copy link
Member Author

This needs #52067, and the mac RBE configs need to be updated to point at 19 instead of 18.

@zanderso
Copy link
Member Author

@jason-simmons some more detail on my above comment: On rolling clang, the mac RBE builds will be broken. The fix is to update the files build/rbe/rewrapper-mac-arm64.cfg and build/rbe/rewrapper-mac-x64.cfg. They contain a path ending in clang/lib/clang/18/include, which has to be updated to clang/lib/clang/19/include. The build/rbe directory is populated from a CIPD package when "use_rbe": True is added to the custom_vars section of the .gclient file. Instructions for updating the CIPD package are in a README.md under build/rbe.

Closing this PR to take it off of the triage list while I'm OOO.

@zanderso zanderso closed this Apr 12, 2024
@zanderso zanderso deleted the roll-clang branch April 12, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant