[Impeller] compute UVs in vertex stage. #52106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
commented
Apr 19, 2024
| @@ -79,7 +80,6 @@ impeller_shaders("modern_entity_shaders") { | |||
| "shaders/gradients/radial_gradient_ssbo_fill.frag", | |||
| "shaders/gradients/sweep_gradient_ssbo_fill.frag", | |||
| "shaders/geometry/points.comp", | |||
| "shaders/geometry/uv.comp", | |||
jonahwilliams
commented
Apr 19, 2024
| float16_t(frag_info.y_tile_mode) // y tile mode | ||
| ) * | ||
| float16_t(frag_info.alpha); | ||
| if (supports_decal == 1.0) { |
There was a problem hiding this comment.
Allows metal, vulkan, and most gles devices to use this shader at no additional cost over the texture_fill shader.
jonahwilliams
commented
Apr 19, 2024
| @@ -129,10 +129,8 @@ using TexturePipeline = | |||
| using TextureStrictSrcPipeline = | |||
| RenderPipelineHandle<TextureFillVertexShader, | |||
| TextureFillStrictSrcFragmentShader>; | |||
| using PositionUVPipeline = RenderPipelineHandle<TextureFillVertexShader, | |||
|
come on goldens, please be good lol |
|
📿 |
|
And we're good |
chinmaygarde
approved these changes
Apr 20, 2024
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 20, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 20, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 21, 2024
…147125) flutter/engine@40110ec...1ac3ce3 2024-04-20 jonahwilliams@google.com [Impeller] compute UVs in vertex stage. (flutter/engine#52106) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jonahwilliams
added a commit
to jonahwilliams/engine
that referenced
this pull request
Apr 22, 2024
This reverts commit 1ac3ce3.
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#147125) flutter/engine@40110ec...1ac3ce3 2024-04-20 jonahwilliams@google.com [Impeller] compute UVs in vertex stage. (flutter/engine#52106) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
Compute texture UVs in the vertex stage. Reland of #52106 which was reverted to investigate golden failures during the x64 to arm64 mac switch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the functionality of texture_fill and tiled_texture_fill vertex stages:
With this functionality, we can delete all of the CPU based uv computation code. Additionally, there is some clean up to remove support for external textures (which use the tiled texture mode) from the texture contents. The external textures are used with an image shader/draw rect by internal engine code and won't go down the drawImageRect path anymore.