-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fuchsia] route fuchsia.sysmem2.Allocator #52187
Conversation
2843af4
to
7db43ca
Compare
cl/627545431 is the test run re. procedure in go/flutter-fuchsia-pr-policy It is passing other than far_placeholder_test failures, which I think can be ignored for purposes of this PR, since the far_placeholder_test(s) are just making sure nobody actually merges a change that modifies the placeholder far files IIUC. |
7db43ca
to
026c587
Compare
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed in a few places. flutter/flutter#146858
026c587
to
ae91af9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
auto label is removed for flutter/engine/52187, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
…147440) flutter/engine@c410180...bc05539 2024-04-26 skia-flutter-autoroll@skia.org Roll Dart SDK from 9936bafe5eb1 to 919c7cab870b (1 revision) (flutter/engine#52407) 2024-04-26 gabeschine@users.noreply.github.com Delete errant back-tick in CONTRIBUTING.md (flutter/engine#52324) 2024-04-26 dustingreen@google.com [fuchsia] route fuchsia.sysmem2.Allocator (flutter/engine#52187) 2024-04-26 jonahwilliams@google.com [Impeller] clamp maximum glyph scale. (flutter/engine#52403) 2024-04-26 zanderso@users.noreply.github.com Add markdown docs about RBE (flutter/engine#52394) 2024-04-26 skia-flutter-autoroll@skia.org Roll Skia from 52083c205016 to 3401ef9641cc (5 revisions) (flutter/engine#52402) 2024-04-26 jason-simmons@users.noreply.github.com Fix function type cast warnings for macOS embedder callbacks (flutter/engine#52377) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed in a few places.
fixes flutter/flutter#146858
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.