-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flutter needs to route fuchsia.sysmem2.Allocator #146858
Flutter needs to route fuchsia.sysmem2.Allocator #146858
Comments
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed anywhere that fake-display is used (in tests). In addition, this change routes fuchsia.sysmem2.Allocator everywhere that fuchsia.sysmem.Allocator is routed (without regard for whether needed by fake-display). This way flutter engine can migrate to fuchsia.sysmem2.Allocator without needing more protocol routing diffs. flutter/flutter#146858
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed anywhere that fake-display is used (in tests). In addition, this change routes fuchsia.sysmem2.Allocator everywhere that fuchsia.sysmem.Allocator is routed (without regard for whether needed by fake-display). This way flutter engine can migrate to fuchsia.sysmem2.Allocator without needing more protocol routing diffs. flutter/flutter#146858
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed anywhere that fake-display is used (in tests). In addition, this change routes fuchsia.sysmem2.Allocator everywhere that fuchsia.sysmem.Allocator is routed (without regard for whether needed by fake-display). This way flutter engine can migrate to fuchsia.sysmem2.Allocator without needing more protocol routing diffs. flutter/flutter#146858
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed anywhere that fake-display is used (in tests). In addition, this change routes fuchsia.sysmem2.Allocator everywhere that fuchsia.sysmem.Allocator is routed (without regard for whether needed by fake-display). This way flutter engine can migrate to fuchsia.sysmem2.Allocator without needing more protocol routing diffs. flutter/flutter#146858
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed anywhere that fake-display is used (in tests). In addition, this change routes fuchsia.sysmem2.Allocator everywhere that fuchsia.sysmem.Allocator is routed (without regard for whether needed by fake-display). This way flutter engine can migrate to fuchsia.sysmem2.Allocator without needing more protocol routing diffs. flutter/flutter#146858
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed in a few places. flutter/flutter#146858
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed in a few places. flutter/flutter#146858
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed in a few places. flutter/flutter#146858
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed in a few places. flutter/flutter#146858
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed. flutter/flutter#146858
Missed a couple needed diffs in shell/platform/fuchsia/flutter/tests/integration/embedder/flutter-embedder-test.cc |
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed. flutter/flutter#146858
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed. flutter/flutter#146858
A few more; will post another PR. |
Route fuchsia.sysmem2.Allocator everywhere that fuchsia.sysmem.Allocator is routed. fixes flutter/flutter#146858
Route fuchsia.sysmem2.Allocator where fuchsia.sysmem.Allocator is routed. fixes flutter/flutter#146858
Route fuchsia.sysmem2.Allocator everywhere that fuchsia.sysmem.Allocator is routed. fixes flutter/flutter#146858
Route fuchsia.sysmem2.Allocator everywhere that fuchsia.sysmem.Allocator is routed. fixes flutter/flutter#146858
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Steps to reproduce
Fuchsia's fake-display will migrate to sysmem2 soon, at which point usages of fake-display (such as in flutter tests) will need to route fuchsia.sysmem2.Allocator.
Expected results
If fuchsia.sysmem2.Allocator is routed, the protocol routing error will be avoided and tests will pass (even with fake-display using fuchsia.sysmem2.Allocator).
Actual results
Fuchsia would log a protocol routing error indicating that fuchsia.sysmem2.Allocator wasn't made available, and some tests would fail. The error would look like this:
Code sample
See the PR for tests that will fail if we don't route fuchsia.sysmem2.Allocator in those tests.
Screenshots or Video
NA
Logs
NA
Flutter Doctor output
NA
The text was updated successfully, but these errors were encountered: