[et] Lookup output filesystem path, not label #52248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
force-pushed
the
et-output-path
branch
from
2f83a74
to
502cf97
Compare
cbracken
force-pushed
the
et-output-path
branch
12 times, most recently
from
b2ad2e8
to
f5fde03
Compare
Sets BuildTarget.executable to the `root_out_dir`-relative path of the executable (e.g. `displaylist_unittests`) instead of its label (e.g. `//out/host_debug/displaylist_unittests`). This is required since, in the lines following the output lookup, we assume it to be a path relative to the build output directory. Also breaks out functions for: * `_gnDesc`: returns the JSON output of `gn desc buildDir target` * `_gnOutputs`: returns the output files listed by `gn outputs buildDir target` Noticed while working on: flutter/flutter#147071
cbracken
force-pushed
the
et-output-path
branch
from
f5fde03
to
51f7612
Compare
cbracken
commented
Apr 21, 2024
| expect(testEnv.processHistory.length, greaterThanOrEqualTo(2)); | ||
| expect(testEnv.processHistory[3].command[0], contains('ninja')); | ||
| expect(testEnv.processHistory[3].command[2], endsWith('/host_debug')); | ||
| expect(testEnv.processHistory.length, greaterThan(6)); |
There was a problem hiding this comment.
Changed to a strictly greater-than check so that it matches the processHistory index we refer to, which will make it a little more obvious to people who modify this in the future.
cbracken
commented
Apr 21, 2024
| @@ -83,7 +85,7 @@ void main() { | |||
| '//third_party/protobuf:protoc', | |||
| ]); | |||
| expect(result, equals(1)); | |||
| expect(testEnvironment.processHistory.length, lessThan(3)); | |||
| expect(testEnvironment.processHistory.length, lessThan(6)); | |||
There was a problem hiding this comment.
Here and in the test above it: This expectation is impacted by implementation details of the test command. I don't think the number of processes executed is the right test, and instead we should just test that test processes are executed and that non-test processes are executed.
I can send out a followup that fixes that. (I realise I also just added this test in a previous patch so I'm 100% to blame for this one :P)
There was a problem hiding this comment.
Yes, I think this count is too brittle. Better to have something like:
expect(testEnvironment.processHistory, executed('gn desc'));
johnmccutchan
approved these changes
Apr 22, 2024
| @@ -83,7 +85,7 @@ void main() { | |||
| '//third_party/protobuf:protoc', | |||
| ]); | |||
| expect(result, equals(1)); | |||
| expect(testEnvironment.processHistory.length, lessThan(3)); | |||
| expect(testEnvironment.processHistory.length, lessThan(6)); | |||
There was a problem hiding this comment.
Yes, I think this count is too brittle. Better to have something like:
expect(testEnvironment.processHistory, executed('gn desc'));
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 22, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 22, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 23, 2024
…147190) flutter/engine@a4b71f0...33c828f 2024-04-22 skia-flutter-autoroll@skia.org Roll Skia from eb29b46236e6 to 3b32e3280b67 (1 revision) (flutter/engine#52298) 2024-04-22 magder@google.com Break dependency cycle of FlutterViewController <-> FlutterPlatformView (flutter/engine#52271) 2024-04-22 chris@bracken.jp [et] Lookup output filesystem path, not label (flutter/engine#52248) 2024-04-22 skia-flutter-autoroll@skia.org Roll Skia from 975859a96f8f to eb29b46236e6 (9 revisions) (flutter/engine#52297) 2024-04-22 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Add configuration for maximum canvases (flutter/engine#51735) 2024-04-22 120297255+PurplePolyhedron@users.noreply.github.com Fix link in BlendMode.saturation (flutter/engine#52156) 2024-04-22 magder@google.com Refactor and migrate FlutterUndoManagerPlugin to ARC (flutter/engine#52234) 2024-04-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Rr9lFiKCPhMXDGa89... to L533ubzhjWwW7jxbc... (flutter/engine#52293) 2024-04-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 0a83dd7e61b1 to 0ed66a4d77cb (1 revision) (flutter/engine#52294) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Rr9lFiKCPhMX to L533ubzhjWwW If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets BuildTarget.executable to the
root_out_dir-relative path of the executable (e.g.displaylist_unittests) instead of its label (e.g.//out/host_debug/displaylist_unittests). This is required since, in the lines following the output lookup, we assume it to be a path relative to the build output directory.Also breaks out functions for:
_runGnDesc: returns the JSON output ofgn desc buildDir target_runGnOutputs: returns the output files listed bygn outputs buildDir targetNoticed while working on: flutter/flutter#147071
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.