Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[et] Lookup output filesystem path, not label #52248

Merged
merged 1 commit into from
Apr 22, 2024
Merged

[et] Lookup output filesystem path, not label #52248

merged 1 commit into from
Apr 22, 2024

Commits on Apr 21, 2024

  1. [et] Lookup output filesystem path, not label 

    Sets BuildTarget.executable to the `root_out_dir`-relative path of the
executable (e.g. `displaylist_unittests`) instead of its label (e.g.
`//out/host_debug/displaylist_unittests`). This is required since, in
the lines following the output lookup, we assume it to be a path
relative to the build output directory.

Also breaks out functions for:
* `_gnDesc`: returns the JSON output of `gn desc buildDir target`
* `_gnOutputs`:  returns the output files listed by `gn outputs buildDir target`

Noticed while working on: flutter/flutter#147071
    @cbracken
    cbracken committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    51f7612 View commit details
    Browse the repository at this point in the history