Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP][canvaskit] fix: consider array size on canvaskit shader data (#49754) #52400

Open
wants to merge 1 commit into
base: flutter-3.19-candidate.1
Choose a base branch
from
Open

[CP][canvaskit] fix: consider array size on canvaskit shader data (#49754) #52400

wants to merge 1 commit into from
+309 −177

Conversation

renancaraujo
Copy link
Contributor

Cherrypick of #49754 that fixed flutter/flutter#141296 and flutter/flutter#141838

This PR changes the ShaderData construction on canvaskit to consider array uniforms.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

@renancaraujo
fix: consider array size on canvaskit shader data (flutter#49754)
8f01f34 
This PR changes the ShaderData construction on canvaskit to consider array uniforms. 

flutter/flutter#141296

flutter/flutter#141838

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@github-actions github-actions bot added the platform-web Code specifically for the web engine label Apr 25, 2024
@renancaraujo renancaraujo mentioned this pull request Apr 25, 2024
Open
@kevmoo
Copy link
Contributor

kevmoo commented May 10, 2024

What's the story here @yjbanov ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
2 participants
@renancaraujo @kevmoo