Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fuchsia] route fuchsia.sysmem2.Allocator pt 2 #52509

Merged
merged 1 commit into from
May 3, 2024

Conversation

dustingreen
Copy link
Contributor

Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed.

fixes flutter/flutter#146858

  • [y] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [y] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • [na] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • [y] I listed at least one issue that this PR fixes in the description above.
  • [fixes to existing tests] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
  • [na] I updated/added relevant documentation (doc comments with ///).
  • [na / googler] I signed the [CLA].
  • [y] All existing and new tests are passing.

@dustingreen
Copy link
Contributor Author

cl/629919249 per go/flutter-fuchsia-pr-policy

@dustingreen dustingreen marked this pull request as ready for review May 2, 2024 04:16
Copy link
Contributor

@jrwang jrwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming google3 presubmit errors are unrelated)

Fuchsia's fake-display will be migrating to sysmem2, which
requires fuchsia.sysmem2.Allocator to be routed.

flutter/flutter#146858
@dustingreen dustingreen merged commit d8c8cf4 into flutter:main May 3, 2024
4 of 23 checks passed
@dustingreen dustingreen deleted the route_sysmem2_pt_2 branch May 3, 2024 01:45
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 3, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 3, 2024
…147763)

flutter/engine@98a800b...d8c8cf4

2024-05-03 dustingreen@google.com [fuchsia] route fuchsia.sysmem2.Allocator pt 2 (flutter/engine#52509)
2024-05-03 jason-simmons@users.noreply.github.com [et] Add Linux host_debug_unopt local engine builder (flutter/engine#52538)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants