Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impeller] Start a glossary. #52641

Merged
merged 2 commits into from
May 8, 2024
Merged

Conversation

chinmaygarde
Copy link
Member

@chinmaygarde
Copy link
Member Author

We are add more items to this stub as time goes on.

impeller/docs/glossary.md Outdated Show resolved Hide resolved
impeller/docs/glossary.md Outdated Show resolved Hide resolved

### EGL

[EGL](https://www.khronos.org/egl) provides [WSI](#window-system-integration-wsi) for OpenGL ES.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it an API or an implementation? the official page is very confusing about exactly what EGL is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT, the API is standardized but the implementation is vendor specific.

Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label May 8, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 8, 2024
Copy link
Contributor

auto-submit bot commented May 8, 2024

auto label is removed for flutter/engine/52641, due to - The status or check suite Mac mac_ios_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chinmaygarde chinmaygarde merged commit bd9ef6a into flutter:main May 8, 2024
22 of 27 checks passed
@chinmaygarde chinmaygarde deleted the glossary branch May 8, 2024 20:16
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 8, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 8, 2024
…148014)

flutter/engine@93c5040...bd58d2b

2024-05-08 skia-flutter-autoroll@skia.org Roll Skia from 4019d8957cff to 76f88de905be (3 revisions) (flutter/engine#52684)
2024-05-08 chinmaygarde@google.com [Impeller] Start a glossary. (flutter/engine#52641)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants