[CP-stable]Update file permissions for FlutterMacOS.framework #52960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During FlutterMacOS.framework engine universal fat framework creation, make sure the framework is `u=rwx,go=rx` when it's created. There's a framework-side workaround in-flight flutter/flutter#148580. However, this is still a good thing to do engine-side, particularly for add-to-app when they don't go through the `flutter assemble` tooling. I'll also add a test around here, once this rolls https://github.com/flutter/flutter/blob/02a6c91e4d37d28f42c8f8e4d4335b0defed41c1/packages/flutter_tools/test/host_cross_arch.shard/macos_content_validation_test.dart#L30 Fixes flutter/flutter#148354 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
flutteractionsbot
added
the
cp: review
|
@jmagman please fill out the PR description above, afterwards the release team will review this request. |
|
Closing, #52930 didn't actually work. I will revert and continue to investigate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link:
Engine part of flutter/flutter#148354
Cherry-pick of #52930
Changelog Description:
Fix file permissions so macOS apps are not rejected from the App Store with the error "The installer package includes files that are only readable by the root user".
Impact Description:
macOS apps may be rejected from the App Store with the error "The installer package includes files that are only readable by the root user".
Workaround:
Locally, from the Flutter SDK directory, run:
If using Codemagic to deploy, add this to the pre-build script:
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
This was manually tested. I will be adding a framework integration to prevent future regressions.
Validation Steps:
Before this change, permission is
drwx------After, permission is