-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't provide system vulkan header paths to Skia. #7003
Conversation
Skia privately brings in its own copy. https://skia-review.googlesource.com/c/skia/+/172147
Not that this PR is to the skia-master branch. |
@liyuqian Are the Cirrus bots wired to take into account the branch from the PR? Or is this still running off of master? I wasn't expecting these jobs to have been triggered. |
My impression is that Cirrus uses whatever branch your local change is based on. If your local change is based on skia-master, then it uses skia-master. If your local change is based on master, then it uses master. If your local change is based on an old master branch, then it uses that old master branch. |
BTW, can we also remove |
No. We still need that header because the embedder implementation needs the Vulkan headers. We just dont need to forward these over to Skia. |
Skia privately brings in its own copy. https://skia-review.googlesource.com/c/skia/+/172147