Merge latest from master => 21008 staging branch #7012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://skia.googlesource.com/skia.git/+log/dfca8f6adb6b..a2272ef92640 Created with: gclient setdep -r src/third_party/skia@a2272ef92640 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
bf26f76 [infra] Ensure that core dump upload triggers on main builders cdf6dde [gardening] bigint_test may still time out when interpreted (2nd try). d3498a8 [vm] Cleanup int overflow checking 9e9746a [gardening] bigint_test may still time out when interpreted. 7de2510 [VM interpreter] Do not interpret some Bigint intrinsics (fixes #34901). 816ab32 Fix versions in spec titles to match the description below c7c81af [vm/bytecode] Check for overflow of bytecode limits 655310d Add ArgumentError.checkNotNull utility 0170b8d Revert "[vm/compiler] Use loop framework for AOT inline heuristics" 9aff930 Move test_methodCallTypeInference_mixinType into mixin_test.dart 3e750a7 [vm] Add test for certain cases of unreachable code daae20d [vm/compiler] Use loop framework for AOT inline heuristics 28a8fa5 Upgrade package:http to 0.12.0. b3055a1 [gardening] Mark co19 LibTest/io/RawDatagramSocket/any_A01_t03 flaky b8fd29e Remove dartfix dependencies on analysis server 8a5405f [build] Add //third_party/android_tools BUILD file needed by zlib 82c1f2a [vm] Eliminate dart_zlib_path from BUILD files 11ad25a Reland "[VM runtime] Support Smi instances in type test cache." 3dc9119 Generate analysis_server_client protocol_generated.dart and related protocol files a902fc3 [gardening] Mark co19 LibTest/io/Stdin/readByteSync_A02_t01 flaky cfecec5 Fix yet another cloning bug d8cb60d [infra] Improve clone command in analyze-flutter.sh script (#34739) 34d0801 Generate analysis server protocol consts in analysis_server_client 2c83eb5 [vm] Integrate dart binary with Crashpad on Windows. b9999b6 [gardening] Mark co19 LibTest/io/RawDatagramSocket/lastWhere_A01_t02 flaky 0b15595 [gardening] Mark co19 LibTest/io/Link/rename_A02_t01 flaky 57f895c Bounds of a generic type alias ensure the body is regular-bounded 6efc58f [vm] Pass member name as a symbol in instantiateInvocation. cf0a99a [fasta] Check type arguments in method invocations while doing inference d693742 Specify for all literals whether the object overrides `Object.==`. 5c90602 Change parameter 'silent' => 'instrumented' e4e82da Changed dartLangSpec errors to warnings 4695b5f Add "convert to int literal" to dartfix 0009ca7 In _matchInterfaceSubtypeOf, account for mixins having null superclass. 1d10e03 [vm/bytecode] Remove unreachable bytecode 03eafc0 Add fromEntries on HashMap and LinkedHashMap 4f2a4e6 new convert-to-int-literal assist 58d73e0 [vm] Remove incorrect assert in Script::GetSnippet 6134ac8 Revert "[VM runtime] Support Smi instances in type test cache." 4e49d19 [gardening] Update status for #34901 6ba3e55 [VM runtime] Support Smi instances in type test cache. e4566d3 LSP: Fix nulls and missing fromJson calls in unions d91e0ad [VM] Make method extractors call a stub for creation of tear-off closure 4c9684f [vm] Ignore compilation errors in CorelibCompileAll b73f7ed [infra] Add tools/bots/find_base_commit.dart 6443a80 Remove flaky markers for standalone_2/io tests, MacOS upgrade seemed to have getten rid underlying OS issue c04215d [fasta] Add a test case for issue #34899 03765ed Update old mixin tests. Remove the --super-mixins flag from the tests. a394e4f Fix handling of JSON with interfaces nested within Unions 2f90f8d Issue 34896. Verify the superconstraint signature invoked by a mixin, not the mixin's one. b82c1f9 Revert "[VM] Fix for issue 34839 - Dart_Cleanup may hang while shutting down" 289d2b0 [vm] Don't re-enqueue functions after unoptimized compiles 33accb5 [VM] : Cleanup the file modified and service stream callbacks in Dart_Cleanup so that the Flutter engine can restart the VM. 89c845e [VM] Fix for issue 34839 - Dart_Cleanup may hang while shutting down the service isolate. e648d63 Revert "Compute unlinked API signatures without unlinked summaries." 74792f4 Revert "[vm] Revert service isolate setup in main.cc" b4fbf1a [vm/bytecode] Wire up bytecode generation in kernel service 914065d [vm/compiler] Use loop framework for register allocator 7fd78ed [infra] Add analyzer branch alias for flutter-analyze builder (#34739) 9406b7b [vm/bytecode] Add versioning to bytecode format a82e025 Move dartfix to its own package 872e901 Set to publish new analyzer_plugin. 2d14d9a Improve how dartfix finds the analysis server pkg root a342cec Disable support for the old super mixins cddc2d4 Handle generic types in LSP spec parsing 8b6f896 Support post-inference serialization/deserialization 9c3834d Remove unused import that shows a warning a1d6137 Exposes VM and Isolate Metrics in the API. 2c6eabd Compute substitution map on kernel objects instead of builders 704a435 Move getSubstitutionMap to KernelClassBuilder af8e291 Respecify where type promotion happens. 393fe44 Resolve types from the class header earlier 1515d4f [Gardening] Mark LibTest/io/RawDatagramSocket/timeout_A06_t01 as flaky 11adb81 Remove the last references to the analyzer package from kernel. 0265151 Fix identifyWidgetExpression() for Flutter. f5cd6cc More shared fasta/analyzer error codes cecda90 Update analyzer docs based on previous feedback ab6eb93 [VM] Fix flaky crash when unwinding the mutator stack during GC
* Update contributing.md for xcode_backend refactor notes
https://skia.googlesource.com/skia.git/+log/a2272ef92640..2cf29ce4dbbf Created with: gclient setdep -r src/third_party/skia@2cf29ce4dbbf The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
https://skia.googlesource.com/skia.git/+log/2cf29ce4dbbf..f5eaee917bb7 Created with: gclient setdep -r src/third_party/skia@f5eaee917bb7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
https://skia.googlesource.com/skia.git/+log/f5eaee917bb7..3f5b4ee4adfd Created with: gclient setdep -r src/third_party/skia@3f5b4ee4adfd The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
https://skia.googlesource.com/skia.git/+log/3f5b4ee4adfd..603c5da17491 Created with: gclient setdep -r src/third_party/skia@603c5da17491 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
https://skia.googlesource.com/skia.git/+log/603c5da17491..e2fd74b48f6f Created with: gclient setdep -r src/third_party/skia@e2fd74b48f6f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
https://skia.googlesource.com/skia.git/+log/e2fd74b48f6f..a944142412cd Created with: gclient setdep -r src/third_party/skia@a944142412cd The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
https://skia.googlesource.com/skia.git/+log/a944142412cd..3b79aa3a5ad0 Created with: gclient setdep -r src/third_party/skia@3b79aa3a5ad0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
* Create FlutterEngine to manage a Shell to support maintaining execution state across instances of FlutterViewControllers * Refactor PlatformViewIOS to support adding or removing a FlutterViewController dynamically * Refactor FlutterDartHeadlessCodeRunner to implement FlutterEngine * Refactor FlutterViewController to accept a FlutterEngine at initialization or to create one for backwards compatibility; any Shell related responsibilities are now passed through to the Engine instance * Remove FlutterNavigationController (unused) * Update all public Objective C doc comments to be consistent and formatable * Add public documentation to all public headers
For flow to manipulate the embedded UIViews during the paint traversal it needs some hook in PaintContext. This PR introduces a ViewEmbeder interface that is implemented by the iOS PlatformViewsController and plumbs it into PaintContext. The ViewEmbedder interface is mainly a place holder at this point, as this PR is focused on just the plumbing.
* Update FlutterPlugin.h docs, suppress warning for older API
On Windows the ERROR macro is defined by some headers which breaks the FML_LOG(ERROR).
https://skia.googlesource.com/skia.git/+log/3b79aa3a5ad0..b53f1f46982d Created with: gclient setdep -r src/third_party/skia@b53f1f46982d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
https://skia.googlesource.com/skia.git/+log/b53f1f46982d..38e4fd0c5654 Created with: gclient setdep -r src/third_party/skia@38e4fd0c5654 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
https://skia.googlesource.com/skia.git/+log/38e4fd0c5654..79c96811863f Created with: gclient setdep -r src/third_party/skia@79c96811863f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
https://skia.googlesource.com/skia.git/+log/79c96811863f..797197a772b8 Created with: gclient setdep -r src/third_party/skia@797197a772b8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
https://skia.googlesource.com/skia.git/+log/797197a772b8..1de48d8040aa Created with: gclient setdep -r src/third_party/skia@1de48d8040aa The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
https://skia.googlesource.com/skia.git/+log/1de48d8040aa..68825776f4b4 Created with: gclient setdep -r src/third_party/skia@68825776f4b4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
The platform views embedding is still WIP, and until we dynamically merge the gpu and platform threads based on the presence of an embedded view in the scene fetching the view embedder is not thread safe. This PR essentially disables iOS platform views embedding, we will re-enable once dynamic thread merging is supported.
https://skia.googlesource.com/skia.git/+log/68825776f4b4..ab18c8e6cc20 Created with: gclient setdep -r src/third_party/skia@ab18c8e6cc20 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Reduces spurious error log messages in GLContextMakeCurrent() attempting set up the GR context: [ERROR:flutter/shell/gpu/gpu_surface_gl.cc(42)] Could not make the context current to setup the gr context.
Pushes the check up front so that we don't always land on the application_kernel_list_asset error message, which may be misleading to readers. Also switches the empty check to only emit in debug builds, since this is almost certainly not a runtime error but a programmer error.
…the header used. (#6949)
Since the migration to Dart 2, the first positional command-line argument to flutter_tester has been a Dart kernel .dill file. Use Settings::application_kernel_asset here for consistency/clarity.
…untryCode exists. Allow language-only locales. (#6995)
matthew-carroll
changed the base branch from
master
to
21008_rewrite-android-embedding-to-reduce-coupling
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
matthew-carroll
force-pushed
the
rewrite-android-embedding_merge-latest-from-master
branch
4 times, most recently
from
9b0d812
to
7317f7f
Compare
matthew-carroll
force-pushed
the
rewrite-android-embedding_merge-latest-from-master
branch
from
7317f7f
to
e866eb7
Compare
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
matthew-carroll
merged commit cae9e71
into
21008_rewrite-android-embedding-to-reduce-coupling
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
matthew-carroll
deleted the
rewrite-android-embedding_merge-latest-from-master
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge latest from master => 21008 staging branch