Add support for sending generated character with key events. #7722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gspencergoog
force-pushed
the
key_character
branch
4 times, most recently
from
a6c4357
to
3fd4ac2
Compare
gspencergoog
force-pushed
the
key_character
branch
from
3fd4ac2
to
4ec8646
Compare
|
/cc @jason-simmons for review |
|
Just noticed #7758. Does that supersede this one? |
|
Oh. Yes. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a "character" key in the key event message that gives the framework the character that was generated as a result of a keypress, including handling combining characters for composed characters.
Also, the "plainCodePoint" is added, which gives the generated Unicode code point as if no modifiers were pressed.
This is needed by the key handling changes for the framework in an upcoming PR.
Submitting this doesn't break anything for existing code (it just sends an extra key that is ignored).