Fix versions implementation #7726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskakaushik
approved these changes
Feb 7, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 7, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Feb 8, 2019
flutter/engine@fdc699b...c40d6da git log fdc699b..c40d6da --no-merges --oneline c40d6da [fuchsia] Update scenic include (flutter/engine#7708) 3c38dd3 Fix versions implementation (flutter/engine#7726) d292ed6 Roll src/third_party/skia c19d81acc096..9564bf44e5fa (5 commits) (flutter/engine#7730) 473097b Roll src/third_party/skia 859db6b5a03c..c19d81acc096 (2 commits) (flutter/engine#7729) d0fee9b Roll src/third_party/dart caa8747a37..6c680a0ebd (12 commits) 6c680a0ebd Update dartfix readme and update version numbers 33337cf8d0 Fix API breakage, reexport ConstantEvaluator. c2cdc1c639 Allow migration of multiple files at once. d68d8526f4 Allow nullabilty migration prepareInput/processInput to operate on different ASTs. 5ecf660b50 [dartdevc] skip co19 tests on linux bots ba9fbda83e Rework provisional migration API. a4b681b83a Update dartdoc to 0.28.1+2. fea5413d5a [ VM ] Fix hang of Flutter engine tests caused by global RuntimeEntry objects being destroyed when exit() is called when the VM hasn't finished shutting down. a5570bd995 [vm/compiler] Add optimization flag f0d5cb73a9 Guard the custom formatter for a Map against errors df779789f2 Support two more cases in the convert-to-spread assist (issue 35867) fd2225ab6c Adapt to the flow analysis spec v2. 168cabc Roll src/third_party/skia f36ad269e88a..859db6b5a03c (1 commits) (flutter/engine#7727) ee0cf82 Correct libraries.yaml path for stub_ui, add brightness, copy dart2js_platform.dill files (flutter/engine#7725) 053f7a8 Roll src/third_party/skia 2fc1474f9d62..f36ad269e88a (2 commits) (flutter/engine#7724) 211adea Introduced a number of Java system channels in io/flutter/embedding/engine/systemchannels/ (flutter/engine#7500) fdf57a6 Roll src/third_party/skia 429251513f71..2fc1474f9d62 (8 commits) (flutter/engine#7721) 77b3186 Roll src/third_party/dart adfa4791fc..caa8747a37 (2 commits) caa8747a37 Rework dartfix NNBD fix to use new NullabilityMigration engine ae5bd68570 Lower relevance of deprecated suggestion sets. 67831a3 Roll buildroot to c82412bcdcd593f1385a478ae2c4b8eb9814f3b8 (flutter/engine#7718) 6585f33 Allow all entrypoints support by the command line VM. (flutter/engine#7717) ce07399 Add FlutterProjectArgs::root_isolate_create_callback (flutter/engine#7651) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop the roller if necessary.
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this pull request
Feb 12, 2019
flutter/engine@fdc699b...c40d6da git log fdc699b..c40d6da --no-merges --oneline c40d6da [fuchsia] Update scenic include (flutter/engine#7708) 3c38dd3 Fix versions implementation (flutter/engine#7726) d292ed6 Roll src/third_party/skia c19d81acc096..9564bf44e5fa (5 commits) (flutter/engine#7730) 473097b Roll src/third_party/skia 859db6b5a03c..c19d81acc096 (2 commits) (flutter/engine#7729) d0fee9b Roll src/third_party/dart caa8747a37..6c680a0ebd (12 commits) 6c680a0ebd Update dartfix readme and update version numbers 33337cf8d0 Fix API breakage, reexport ConstantEvaluator. c2cdc1c639 Allow migration of multiple files at once. d68d8526f4 Allow nullabilty migration prepareInput/processInput to operate on different ASTs. 5ecf660b50 [dartdevc] skip co19 tests on linux bots ba9fbda83e Rework provisional migration API. a4b681b83a Update dartdoc to 0.28.1&flutter#43;2. fea5413d5a [ VM ] Fix hang of Flutter engine tests caused by global RuntimeEntry objects being destroyed when exit() is called when the VM hasn&flutter#39;t finished shutting down. a5570bd995 [vm/compiler] Add optimization flag f0d5cb73a9 Guard the custom formatter for a Map against errors df779789f2 Support two more cases in the convert-to-spread assist (issue 35867) fd2225ab6c Adapt to the flow analysis spec v2. 168cabc Roll src/third_party/skia f36ad269e88a..859db6b5a03c (1 commits) (flutter/engine#7727) ee0cf82 Correct libraries.yaml path for stub_ui, add brightness, copy dart2js_platform.dill files (flutter/engine#7725) 053f7a8 Roll src/third_party/skia 2fc1474f9d62..f36ad269e88a (2 commits) (flutter/engine#7724) 211adea Introduced a number of Java system channels in io/flutter/embedding/engine/systemchannels/ (flutter/engine#7500) fdf57a6 Roll src/third_party/skia 429251513f71..2fc1474f9d62 (8 commits) (flutter/engine#7721) 77b3186 Roll src/third_party/dart adfa4791fc..caa8747a37 (2 commits) caa8747a37 Rework dartfix NNBD fix to use new NullabilityMigration engine ae5bd68570 Lower relevance of deprecated suggestion sets. 67831a3 Roll buildroot to c82412bcdcd593f1385a478ae2c4b8eb9814f3b8 (flutter/engine#7718) 6585f33 Allow all entrypoints support by the command line VM. (flutter/engine#7717) ce07399 Add FlutterProjectArgs::root_isolate_create_callback (flutter/engine#7651) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop the roller if necessary.
iskakaushik
pushed a commit
to iskakaushik/engine
that referenced
this pull request
Feb 14, 2019
This reverts commit 3c38dd3.
iskakaushik
pushed a commit
to iskakaushik/engine
that referenced
this pull request
Apr 11, 2019
This reverts commit 3c38dd3.
iskakaushik
added a commit
that referenced
this pull request
Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As implemented currently, versions throws an error because of an off-by-one issue with the native registration:
Unfortunately, the test wasn't actually testing the implementation. It looks like the test file was modeled after window_hooks_integration_test.dart, which needs to fake being part of dart:ui to access internals. We really should just rewrite that so we're not testing internal implementation details, or so that we're exposing relevant bits (see flutter/flutter#27628)
I've updated the native registration and the test.