Make Rect and RRect use 64 bit doubles, and make them const-able #8565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Apr 12, 2019
| blRadiusY: radiusY, | ||
| brRadiusX: radiusX, | ||
| brRadiusY: radiusY, | ||
| ); |
There was a problem hiding this comment.
rather than a ._raw constructor you could also just inline the initializers in each constructor
There was a problem hiding this comment.
The _raw constructor asserts everything is not null.
Hixie
reviewed
Apr 12, 2019
| @@ -1438,38 +1451,38 @@ class RRect { | |||
| if (point.dx < left || point.dx >= right || point.dy < top || point.dy >= bottom) | |||
| return false; // outside bounding box | |||
|
|
|||
| _scaleRadii(); | |||
| final RRect scaled = _scaleRadii(); | |||
There was a problem hiding this comment.
since we're not caching that work anymore, this may have perf implications.
we should make sure we have a benchmark that covers the case here (of calling contains many times on the same rrects).
There was a problem hiding this comment.
flutter/flutter#30985 will track that
Hixie
reviewed
Apr 12, 2019
Hixie
reviewed
Apr 12, 2019
9 tasks
cbracken
reviewed
Apr 22, 2019
| : assert(left != null), | ||
| assert(top != null), | ||
| assert(right != null), | ||
| assert(bottom != null); |
There was a problem hiding this comment.
Same as last time, remember to mark the const linter warnings as ignore until we've rolled internally and embedders have been updated.
|
I will be opening a manual Flutter roll to land this. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 22, 2019
This was referenced Apr 22, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 22, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 22, 2019
dnfield
added a commit
to dnfield/engine
that referenced
this pull request
Apr 22, 2019
…ble (flutter#8565)" This reverts commit c123152.
dnfield
added a commit
that referenced
this pull request
Apr 22, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 22, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 23, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 23, 2019
flutter/engine@934772d...0523870 git log 934772d..0523870 --no-merges --oneline 0523870 Add tests from framework (flutter/engine#8692) ed1f3fd Change Vertices.indices to use a Uint16 list to more accurately reflect Skia's API (flutter/engine#8657) 4f2fd84 Revert Rect/RRect 64 bit (flutter/engine#8690) 6dc5dca Revert "Remove unused Settings::ToString. (#8642)" (flutter/engine#8689) 9fa7336 fix toString (flutter/engine#8688) c123152 Make Rect and RRect use 64 bit doubles, and make them const-able (flutter/engine#8565) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relands work done by @HansMuller in #8524 with a couple changes:
doubleinstead of aFloat64List, so we can make at least some constructorsconstRRect.This will need to be manually rolled into the framework to update the Semantics traversal test, due to precision differences in the Rect thatimpact that test (as documented in flutter/flutter#30942). That PR updates a few places that can be made to work with both 32 and 64 bit doubles.
Fixes flutter/flutter#27320