Send timings of the first frame without batching #9424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For flutter/flutter#34867 Test added: ReportTimingsIsCalledImmediatelyAfterTheFirstFrame
| // Create the surface needed by rasterizer | ||
| PlatformViewNotifyCreated(shell.get()); | ||
|
|
||
| auto configuration = RunConfiguration::InferFromSettings(settings); |
There was a problem hiding this comment.
How is this working? You just moved the settings into the CreateShell call? Either make it const or don't move it.
There was a problem hiding this comment.
Oops, it seems that I forgot to remove std::move when I removed && in the last PR. By the fact that all tests have passed in these days, it seems to me that std::move may just be a no-op here?
Anyway, std::move removed.
chinmaygarde
approved these changes
Jun 24, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 24, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jun 24, 2019
flutter/engine@297cbd4...b188479 git log 297cbd4..b188479 --no-merges --oneline b188479 Remove variants of ParagraphBuilder::AddText that are not used within the engine (flutter/engine#9403) a184037 Send timings of the first frame without batching (flutter/engine#9424) 215096c Roll src/third_party/skia 91032f8cd7ea..d8f79a27b06b (16 commits) (flutter/engine#9457) 52ebf4c Made sure that the run_tests script returns the right error code. (flutter/engine#9456) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop the roller if necessary.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
flutter/engine@297cbd4...b188479 git log 297cbd4..b188479 --no-merges --oneline b188479 Remove variants of ParagraphBuilder::AddText that are not used within the engine (flutter/engine#9403) a184037 Send timings of the first frame without batching (flutter/engine#9424) 215096c Roll src/third_party/skia 91032f8cd7ea..d8f79a27b06b (16 commits) (flutter/engine#9457) 52ebf4c Made sure that the run_tests script returns the right error code. (flutter/engine#9456) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For flutter/flutter#34867
Test added: