Code completion should insert placeholders for @required parameters

[mit-mit]

Repro steps:

1. Create a new Flutter project in IJ
2. Delete new Text( 'Button tapped $_counter time${ _counter == 1 ? '' : 's' }.', ) in line 80
3. Type new Pad and complete to Padding

Expected result: Editor completes:

child:

to:

child: new Padding(
  padding: ,
),

thus making it clear that a padding argument is required.

Actual result: Editor completes to just new Padding()

[eseidelGoogle]

This feature sounds like a great carrot to encourage dart package authors (and flutter framework authors) to annotate @required correctly. :)

[devoncarew]

Not sure if there's an is an issue for the associated quick-fix for this -

[pq]

Not sure if there's an is an issue for the associated quick-fix for this -

Quick-fixes landed last week.

🤘

Hope to dig into completions this week.

[pq]

A little refinement to the proposal.

Instead of:

child: new Padding(
  padding: ,
),

I think we want:

child: new Padding(
  padding: null,
),

since it will parse cleanly.

[mit-mit]

That sounds right. And then the Flutter framework should be updated to mark child @required so that the expansion becomes:

   child: new Padding(
     padding: null,
     child: null,
   ),

[pq]

As of dart-lang/sdk@cc0036d, support is in place on the DAS side. Once JetBrains/intellij-plugins#495 lands, completions in IDEA will go from a proposal like this

to generated code like this

(Note that x, y and null are linked edits and you can TAB between them.)

FYI @sethladd

[sethladd]

Um, that's awesome. Nice work!

[mit-mit]

Oh, this looks super awesome!

…

On Thu, Mar 2, 2017 at 10:33 PM, Seth Ladd ***@***.***> wrote: Um, that's awesome. Nice work! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#553 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANAximhvTaFQPI1F_pfE8FnpSiayoXVJks5rhzWQgaJpZM4LOHLT> .

[devoncarew]

Very cool!

[pq]

As of dart-lang/sdk@f33d072, completion on Padding looks like:

👍

The relevant framework bits in IDEA landed in JetBrains/intellij-plugins@314c62a, and will be available in the next release of the Dart Plugin.

There's a continuing discussion of the treatment of non-required but possibly still desirable boiler-plate generation in #463.

Note that getting the required analysis bits into Flutter is gated by flutter/flutter#8812.

Since this is just gated by updates upstream, closing here.

[sethladd]

Very cool!

[tolotrasamuel]

@pq I have the latest Dart and Flutter plugin on Android studio but the code completion does not place cursor on null, it just sets it to null.