Skip to content

Commit

Permalink
Remove add-to-app bitcode warning (#148587)
Browse files Browse the repository at this point in the history
Flutter deprecated bitcode in 2022 #112828, and introduced a warning in #112900 to let add-to-app devs know.

Apps should be migrated by now, remove the outdated warning.
  • Loading branch information
jmagman committed May 20, 2024
1 parent 5890a2f commit 165e535
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 10 deletions.
7 changes: 1 addition & 6 deletions dev/devicelab/bin/tasks/build_ios_framework_module_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,7 @@ Future<void> _testBuildIosFramework(Directory projectDir, { bool isModule = fals
const String outputDirectoryName = 'flutter-frameworks';

await inDirectory(projectDir, () async {
final StringBuffer outputError = StringBuffer();
await evalFlutter(
await flutter(
'build',
options: <String>[
'ios-framework',
Expand All @@ -97,11 +96,7 @@ Future<void> _testBuildIosFramework(Directory projectDir, { bool isModule = fals
'--obfuscate',
'--split-debug-info=symbols',
],
stderr: outputError,
);
if (!outputError.toString().contains('Bitcode support has been deprecated.')) {
throw TaskResult.failure('Missing bitcode deprecation warning');
}
});

final String outputPath = path.join(projectDir.path, outputDirectoryName);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -330,10 +330,6 @@ class BuildIOSFrameworkCommand extends BuildFrameworkCommand {
'See https://flutter.dev/docs/development/add-to-app/ios/add-flutter-screen#create-a-flutterengine for more information.');
}

globals.printWarning(
'Bitcode support has been deprecated. Turn off the "Enable Bitcode" build setting in your Xcode project or you may encounter compilation errors.\n'
'See https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes for details.');

return FlutterCommandResult.success();
}

Expand Down

0 comments on commit 165e535

Please sign in to comment.