Add bitcode deprecation note for add-to-app iOS developers #112900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
added
platform-ios
flutter-dashboard
bot
added
the
team
17 tasks
| @@ -87,7 +87,8 @@ Future<void> _testBuildIosFramework(Directory projectDir, { bool isModule = fals | |||
| const String outputDirectoryName = 'flutter-frameworks'; | |||
|
|
|||
| await inDirectory(projectDir, () async { | |||
| await flutter( | |||
| final StringBuffer outputError = StringBuffer(); | |||
| final String output = await evalFlutter( | |||
There was a problem hiding this comment.
RUNNING: cd .; bin/flutter analyze --flutter-repo
Analyzing 3 items...
info • The value of the local variable 'output' isn't used • dev/devicelab/bin/tasks/build_ios_framework_module_test.dart:91:18 • unused_local_variable
1 issue found. (ran in 122.4s)
This was referenced Oct 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitcode has been deprecated. Existing Flutter apps were migrated in #112828, but we have no control over iOS add-to-app host apps. Give developers a warning that they need to turn off the build setting in the Xcode host app.