Skip to content

Commit

Permalink
Revert "[Re-land] Exposed tooltip longPress (#118796)" (#119832)
Browse files Browse the repository at this point in the history
This reverts commit d278808.
  • Loading branch information
esouthren committed Feb 2, 2023
1 parent 9eafbcc commit 1ee8799
Show file tree
Hide file tree
Showing 9 changed files with 3 additions and 28 deletions.
2 changes: 1 addition & 1 deletion packages/flutter/lib/src/material/tooltip.dart
Expand Up @@ -751,7 +751,7 @@ class TooltipState extends State<Tooltip> with SingleTickerProviderStateMixin {
behavior: HitTestBehavior.opaque,
onLongPress: (_triggerMode == TooltipTriggerMode.longPress) ? _handlePress : null,
onTap: (_triggerMode == TooltipTriggerMode.tap) ? _handleTap : null,
excludeFromSemantics: _excludeFromSemantics,
excludeFromSemantics: true,
child: result,
);
// Only check for hovering if there is a mouse connected.
Expand Down
2 changes: 0 additions & 2 deletions packages/flutter/test/material/back_button_test.dart
Expand Up @@ -172,7 +172,6 @@ void main() {
hasEnabledState: true,
isEnabled: true,
hasTapAction: true,
hasLongPressAction: true,
isFocusable: true,
));
handle.dispose();
Expand Down Expand Up @@ -217,7 +216,6 @@ void main() {
hasEnabledState: true,
isEnabled: true,
hasTapAction: true,
hasLongPressAction: true,
isFocusable: true,
));
handle.dispose();
Expand Down
2 changes: 0 additions & 2 deletions packages/flutter/test/material/calendar_date_picker_test.dart
Expand Up @@ -672,7 +672,6 @@ void main() {
tooltip: 'Previous month',
isButton: true,
hasTapAction: true,
hasLongPressAction: true,
isEnabled: true,
hasEnabledState: true,
isFocusable: true,
Expand All @@ -681,7 +680,6 @@ void main() {
tooltip: 'Next month',
isButton: true,
hasTapAction: true,
hasLongPressAction: true,
isEnabled: true,
hasEnabledState: true,
isFocusable: true,
Expand Down
5 changes: 1 addition & 4 deletions packages/flutter/test/material/chip_test.dart
Expand Up @@ -2047,10 +2047,7 @@ void main() {
children: <TestSemantics>[
TestSemantics(
tooltip: 'Delete',
actions: <SemanticsAction>[
SemanticsAction.tap,
SemanticsAction.longPress
],
actions: <SemanticsAction>[SemanticsAction.tap],
textDirection: TextDirection.ltr,
flags: <SemanticsFlag>[
SemanticsFlag.isButton,
Expand Down
2 changes: 0 additions & 2 deletions packages/flutter/test/material/date_picker_test.dart
Expand Up @@ -833,7 +833,6 @@ void main() {
tooltip: 'Switch to input',
isButton: true,
hasTapAction: true,
hasLongPressAction: true,
isEnabled: true,
hasEnabledState: true,
isFocusable: true,
Expand Down Expand Up @@ -877,7 +876,6 @@ void main() {
tooltip: 'Switch to calendar',
isButton: true,
hasTapAction: true,
hasLongPressAction: true,
isEnabled: true,
hasEnabledState: true,
isFocusable: true,
Expand Down
Expand Up @@ -700,7 +700,6 @@ void main() {
tooltip: 'Add Photo',
actions: <SemanticsAction>[
SemanticsAction.tap,
SemanticsAction.longPress,
],
flags: <SemanticsFlag>[
SemanticsFlag.hasEnabledState,
Expand Down
5 changes: 1 addition & 4 deletions packages/flutter/test/material/search_test.dart
Expand Up @@ -620,10 +620,7 @@ void main() {
SemanticsFlag.isEnabled,
SemanticsFlag.isFocusable,
],
actions: <SemanticsAction>[
SemanticsAction.tap,
SemanticsAction.longPress,
],
actions: <SemanticsAction>[SemanticsAction.tap],
tooltip: 'Back',
textDirection: TextDirection.ltr,
),
Expand Down
6 changes: 0 additions & 6 deletions packages/flutter/test/material/tooltip_test.dart
Expand Up @@ -1416,9 +1416,6 @@ void main() {
id: 1,
tooltip: 'TIP',
textDirection: TextDirection.ltr,
actions: <SemanticsAction>[
SemanticsAction.longPress,
],
),
],
);
Expand Down Expand Up @@ -1619,9 +1616,6 @@ void main() {
tooltip: 'Foo',
label: 'Bar',
textDirection: TextDirection.ltr,
actions: <SemanticsAction>[
SemanticsAction.longPress,
],
),
],
),
Expand Down
6 changes: 0 additions & 6 deletions packages/flutter/test/material/tooltip_theme_test.dart
Expand Up @@ -1075,9 +1075,6 @@ void main() {
tooltip: 'Foo',
label: 'Bar',
textDirection: TextDirection.ltr,
actions: <SemanticsAction>[
SemanticsAction.longPress,
],
),
],
),
Expand Down Expand Up @@ -1121,9 +1118,6 @@ void main() {
tooltip: 'Foo',
label: 'Bar',
textDirection: TextDirection.ltr,
actions: <SemanticsAction>[
SemanticsAction.longPress,
],
),
],
),
Expand Down

0 comments on commit 1ee8799

Please sign in to comment.