Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Re-land] Exposed tooltip longPress #118796

Merged
merged 4 commits into from Feb 1, 2023
Merged

[Re-land] Exposed tooltip longPress #118796

merged 4 commits into from Feb 1, 2023

Conversation

esouthren
Copy link
Contributor

Re-land of #117338, which fixes b/239606811.

The fix for the cause of the reverting was merged in https://github.com/flutter/flutter/pull/117547/files.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jan 19, 2023
@google-cla
Copy link

google-cla bot commented Jan 19, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@liumcse @TahaTesser @esouthren
Check whether slider is mounted before interaction, no-op if unmounted (
3e303c5 
flutter#113556)

* Check whether slider is unmounted before interaction

* Update slider.dart

* Update Slider

* Add test

* Update slider_test.dart

* Update packages/flutter/test/material/slider_test.dart

Co-authored-by: Taha Tesser <tessertaha@gmail.com>

Co-authored-by: Taha Tesser <tessertaha@gmail.com>
@esouthren esouthren marked this pull request as ready for review January 21, 2023 12:49
guidezpl
guidezpl approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

@esouthren esouthren merged commit d278808 into flutter:master Feb 1, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2023
@engine-flutter-autoroll
d27880801 [Re-land] Exposed tooltip longPress (flutter/flutter#118796)
ccccb25
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 1, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 1, 2023
@engine-flutter-autoroll
d278808 [Re-land] Exposed tooltip longPress (flutter/flutter#118796)
723b90b
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Feb 1, 2023
@engine-flutter-autoroll
Roll Flutter from 0a22a1d to d278808 (58 revisions) (#7078)
36d8066 
* 472b887 0ec8e2802 Roll Fuchsia Mac SDK from 9y7C2oamTv6Py4JSC... to EAFnGijD0l5QxaPxF... (flutter/engine#39236) (flutter/flutter#119461)

* 15cd00f a7bb0e410 Roll Fuchsia Linux SDK from 1D63BqURfJdG4r3CK... to xTXbcsPr5GJvFSLha... (flutter/engine#39238) (flutter/flutter#119482)

* 530c3f2 [Re-land#2] Button padding M3 (flutter/flutter#119498)

* 17eb2e8 Ability to disable the browser's context menu on web (flutter/flutter#118194)

* df8ad3d roll packages (flutter/flutter#119370)

* b68cebd roll packages (flutter/flutter#119530)

* 59d80dc [Android] Add explicit exported tag to Linux_android flavors test (flutter/flutter#117542)

* 458b298 Refactoring to use `ver` command instead of `systeminfo` (flutter/flutter#119304)

* 54405bf fixes PointerEventConverter to handle malformed scrolling event (flutter/flutter#118124)

* e69ea6d Support flipping mouse scrolling axes through modifier keys (flutter/flutter#115610)

* 92df6b4 396c7fd0b Reland "Remove references to Observatory (#38919)" (flutter/engine#39139) (flutter/flutter#119546)

* 7477d7a Reland "Add --serve-observatory flag to run, attach, and test (#118402)" (flutter/flutter#119529)

* 6c12e39 Introduce ParagraphBoundary subclass for text editing (flutter/flutter#116549)

* b227df3 Hint text semantics to be excluded in a11y read out if hintText is not visible. (flutter/flutter#119198)

* 18c7f8a Fix typo in --machine help text (flutter/flutter#119563)

* 329f86a Make a few values non-nullable in cupertino (flutter/flutter#119478)

* c4520bc b2efe0175 [web] Expose felt flag for building CanvasKit Chromium (flutter/engine#39201) (flutter/flutter#119567)

* 8898f4f Marks Mac_android run_debug_test_android to be unflaky (flutter/flutter#117468)

* 1f0b6fb Remove deprecated AppBar/SliverAppBar/AppBarTheme.textTheme member (flutter/flutter#119253)

* edaeec8 Roll Flutter Engine from b2efe01754ef to 5011144c0b46 (3 revisions) (flutter/flutter#119578)

* 865dc5c Roll Flutter Engine from 5011144c0b46 to daa8eeb7fc0b (2 revisions) (flutter/flutter#119584)

* 1148a2a Migrate EditableTextState from addPostFrameCallbacks to compositionCallbacks (flutter/flutter#119359)

* 2340902 Roll Flutter Engine from daa8eeb7fc0b to 77218818138f (3 revisions) (flutter/flutter#119586)

* 65900b7 Remove deprecated AnimatedSize.vsync parameter (flutter/flutter#119186)

* 5b6572f Add debug diagnostics to channels integration test (flutter/flutter#119579)

* 504e565 Roll Flutter Engine from 77218818138f to 9448f2966c11 (3 revisions) (flutter/flutter#119592)

* 7ba4406 Revert "[Re-land#2] Button padding M3 (#119498)" (flutter/flutter#119597)

* 2c34a88 Roll Flutter Engine from 9448f2966c11 to 72abe0e4b828 (3 revisions) (flutter/flutter#119603)

* df0ab40 Roll Plugins from ff84c44 to 9da327c (15 revisions) (flutter/flutter#119629)

* 67d07a6 [flutter_tools] Fix parsing of existing DDS URIs from exceptions (flutter/flutter#119506)

* d272a3a Reland: [macos] add flavor options to tool commands (flutter/flutter#119564)

* a16d82c aa00da3c1 Roll Skia from fc31f43cc40a to 3c6eb76a683a (1 revision) (flutter/engine#39280) (flutter/flutter#119605)

* f6b0c6d Use first Dart VM Service found with mDNS if there are duplicates (flutter/flutter#119545)

* d4c7485 Make Decoration.padding non-nullable (flutter/flutter#119581)

* 2fccf4d Remove MediaQuery from WidgetsApp (flutter/flutter#119377)

* 9b3b9cf Roll Flutter Engine from aa00da3c1612 to cd2e8885e491 (6 revisions) (flutter/flutter#119639)

* 6a54059 Make MultiChildRenderObjectWidget const (flutter/flutter#119195)

* e2b3d89 Fix CupertinoNavigationBar should create a backward compatible Annota… (flutter/flutter#119515)

* 7bf95f4 1aaf3db31 Roll Dart SDK from 4fdbc7c28141 to 9bcc1773ebf0 (1 revision) (flutter/engine#39290) (flutter/flutter#119640)

* 0e22aca Add support for image insertion on Android (flutter/flutter#110052)

* ff22813 separatorBuilder can't return null (flutter/flutter#119566)

* 60c1f29 2471f430f Update buildroot to c02da5072d1bb2. (flutter/engine#39292) (flutter/flutter#119645)

* fbe9ff3 Disable an inaccurate test assertion that will be fixed by an engine roll (flutter/flutter#119653)

* 8f90e2a Roll Flutter Engine from 2471f430ff4b to bb7b7006f4a3 (2 revisions) (flutter/flutter#119655)

* 3884381 Make gen-l10n error handling independent of logger state (flutter/flutter#119644)

* 198a51a Migrate the Material Date pickers to M3 Reprise (flutter/flutter#119033)

* dc86565 Roll Flutter Engine from bb7b7006f4a3 to 521b975449ba (4 revisions) (flutter/flutter#119670)

* 82df235 Undo making Flex,Row,Column const (flutter/flutter#119669)

* 6f9a896 Roll Flutter Engine from 521b975449ba to 38913c5484cf (2 revisions) (flutter/flutter#119675)

* 8d0af36 🥅 Produce warning instead of error for storage base url overrides (flutter/flutter#119595)

* 3894d24 1703a3966 Roll Skia from c29211525dac to 654f4805e8b8 (21 revisions) (flutter/engine#39309) (flutter/flutter#119683)

* a752c2f Expose enableIMEPersonalizedLearning on CupertinoSearchTextField (flutter/flutter#119439)

* e1f0b1d d92e23cb5 Roll Skia from 654f4805e8b8 to da41cf18f651 (1 revision) (flutter/engine#39311) (flutter/flutter#119686)

* 97d273c CupertinoThemeData equality (flutter/flutter#119480)

* 4167835 5b549950f Roll Fuchsia Linux SDK from 71lEeibIyrq0V8jId... to TFcelQ5SwrzkcYK2d... (flutter/engine#39312) (flutter/flutter#119688)

* b4a6e34 0d87b1562 Roll Dart SDK from 8b57d23a7246 to de03e1f41b50 (1 revision) (flutter/engine#39313) (flutter/flutter#119695)

* 3af30ff Roll Flutter Engine from 0d87b156265c to c08a286d60e9 (3 revisions) (flutter/flutter#119706)

* d278808 [Re-land] Exposed tooltip longPress (flutter/flutter#118796)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2023
@engine-flutter-autoroll
d27880801 [Re-land] Exposed tooltip longPress (flutter/flutter#118796)
b6e52a1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 1, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2023
@engine-flutter-autoroll
d27880801 [Re-land] Exposed tooltip longPress (flutter/flutter#118796)
41d2599
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 1, 2023
@engine-flutter-autoroll
Roll Flutter from 9b3b9cf0893d to 1573c12963c6 (24 revisions) (#3140)
5d10e8b 
* 6a5405925 Make MultiChildRenderObjectWidget const (flutter/flutter#119195)

* e2b3d89e7 Fix CupertinoNavigationBar should create a backward compatible Annota… (flutter/flutter#119515)

* 7bf95f41e 1aaf3db31 Roll Dart SDK from 4fdbc7c28141 to 9bcc1773ebf0 (1 revision) (flutter/engine#39290) (flutter/flutter#119640)

* 0e22aca78 Add support for image insertion on Android (flutter/flutter#110052)

* ff22813b7 separatorBuilder can't return null (flutter/flutter#119566)

* 60c1f293d 2471f430f Update buildroot to c02da5072d1bb2. (flutter/engine#39292) (flutter/flutter#119645)

* fbe9ff33e Disable an inaccurate test assertion that will be fixed by an engine roll (flutter/flutter#119653)

* 8f90e2a7d Roll Flutter Engine from 2471f430ff4b to bb7b7006f4a3 (2 revisions) (flutter/flutter#119655)

* 388438141 Make gen-l10n error handling independent of logger state (flutter/flutter#119644)

* 198a51ace Migrate the Material Date pickers to M3 Reprise (flutter/flutter#119033)

* dc8656594 Roll Flutter Engine from bb7b7006f4a3 to 521b975449ba (4 revisions) (flutter/flutter#119670)

* 82df23539 Undo making Flex,Row,Column const (flutter/flutter#119669)

* 6f9a896d7 Roll Flutter Engine from 521b975449ba to 38913c5484cf (2 revisions) (flutter/flutter#119675)

* 8d0af3679 🥅 Produce warning instead of error for storage base url overrides (flutter/flutter#119595)

* 3894d2481 1703a3966 Roll Skia from c29211525dac to 654f4805e8b8 (21 revisions) (flutter/engine#39309) (flutter/flutter#119683)

* a752c2f15 Expose enableIMEPersonalizedLearning on CupertinoSearchTextField (flutter/flutter#119439)

* e1f0b1d14 d92e23cb5 Roll Skia from 654f4805e8b8 to da41cf18f651 (1 revision) (flutter/engine#39311) (flutter/flutter#119686)

* 97d273ce1 CupertinoThemeData equality (flutter/flutter#119480)

* 416783503 5b549950f Roll Fuchsia Linux SDK from 71lEeibIyrq0V8jId... to TFcelQ5SwrzkcYK2d... (flutter/engine#39312) (flutter/flutter#119688)

* b4a6e349a 0d87b1562 Roll Dart SDK from 8b57d23a7246 to de03e1f41b50 (1 revision) (flutter/engine#39313) (flutter/flutter#119695)

* 3af30ff59 Roll Flutter Engine from 0d87b156265c to c08a286d60e9 (3 revisions) (flutter/flutter#119706)

* d27880801 [Re-land] Exposed tooltip longPress (flutter/flutter#118796)

* 254a796bc Revert "Reland "Add --serve-observatory flag to run, attach, and test (#118402)" (#119529)" (flutter/flutter#119729)

* 1573c1296 Marks Mac_android microbenchmarks to be unflaky (flutter/flutter#119727)
@jmagman jmagman mentioned this pull request Feb 1, 2023
Closed
@jmagman
Copy link
Member

jmagman commented Feb 1, 2023

This caused a new test failure: #119759

esouthren added a commit that referenced this pull request Feb 2, 2023
@esouthren
Revert "[Re-land] Exposed tooltip longPress (#118796)"
b504f28 
This reverts commit d278808.
@esouthren esouthren mentioned this pull request Feb 2, 2023
Merged
esouthren added a commit that referenced this pull request Feb 2, 2023
@esouthren
Revert "[Re-land] Exposed tooltip longPress (#118796)" (#119832)
1ee8799 
This reverts commit d278808.
CaseyHillers added a commit that referenced this pull request Feb 2, 2023
@CaseyHillers
Revert "[Re-land] Exposed tooltip longPress (#118796)"
04b6907 
This reverts commit d278808.
@CaseyHillers CaseyHillers mentioned this pull request Feb 2, 2023
Closed
CaseyHillers pushed a commit that referenced this pull request Feb 2, 2023
@esouthren
Revert "[Re-land] Exposed tooltip longPress (#118796)" (#119832) (#11…
c22ea11 
…9843)

This reverts commit d278808.

Co-authored-by: Eilidh Southren <esouthren@google.com>
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request Feb 2, 2023
@esouthren
Revert "[Re-land] Exposed tooltip longPress (flutter#118796)" (flutte…
19364de 
…r#119832)

This reverts commit d278808.
Maatteogekko pushed a commit to Maatteogekko/packages that referenced this pull request Feb 4, 2023
@engine-flutter-autoroll @Maatteogekko
Roll Flutter from 9b3b9cf0893d to 1573c12963c6 (24 revisions) (flutte…
d42f51c 
…r#3140)

* 6a5405925 Make MultiChildRenderObjectWidget const (flutter/flutter#119195)

* e2b3d89e7 Fix CupertinoNavigationBar should create a backward compatible Annota… (flutter/flutter#119515)

* 7bf95f41e 1aaf3db31 Roll Dart SDK from 4fdbc7c28141 to 9bcc1773ebf0 (1 revision) (flutter/engine#39290) (flutter/flutter#119640)

* 0e22aca78 Add support for image insertion on Android (flutter/flutter#110052)

* ff22813b7 separatorBuilder can't return null (flutter/flutter#119566)

* 60c1f293d 2471f430f Update buildroot to c02da5072d1bb2. (flutter/engine#39292) (flutter/flutter#119645)

* fbe9ff33e Disable an inaccurate test assertion that will be fixed by an engine roll (flutter/flutter#119653)

* 8f90e2a7d Roll Flutter Engine from 2471f430ff4b to bb7b7006f4a3 (2 revisions) (flutter/flutter#119655)

* 388438141 Make gen-l10n error handling independent of logger state (flutter/flutter#119644)

* 198a51ace Migrate the Material Date pickers to M3 Reprise (flutter/flutter#119033)

* dc8656594 Roll Flutter Engine from bb7b7006f4a3 to 521b975449ba (4 revisions) (flutter/flutter#119670)

* 82df23539 Undo making Flex,Row,Column const (flutter/flutter#119669)

* 6f9a896d7 Roll Flutter Engine from 521b975449ba to 38913c5484cf (2 revisions) (flutter/flutter#119675)

* 8d0af3679 🥅 Produce warning instead of error for storage base url overrides (flutter/flutter#119595)

* 3894d2481 1703a3966 Roll Skia from c29211525dac to 654f4805e8b8 (21 revisions) (flutter/engine#39309) (flutter/flutter#119683)

* a752c2f15 Expose enableIMEPersonalizedLearning on CupertinoSearchTextField (flutter/flutter#119439)

* e1f0b1d14 d92e23cb5 Roll Skia from 654f4805e8b8 to da41cf18f651 (1 revision) (flutter/engine#39311) (flutter/flutter#119686)

* 97d273ce1 CupertinoThemeData equality (flutter/flutter#119480)

* 416783503 5b549950f Roll Fuchsia Linux SDK from 71lEeibIyrq0V8jId... to TFcelQ5SwrzkcYK2d... (flutter/engine#39312) (flutter/flutter#119688)

* b4a6e349a 0d87b1562 Roll Dart SDK from 8b57d23a7246 to de03e1f41b50 (1 revision) (flutter/engine#39313) (flutter/flutter#119695)

* 3af30ff59 Roll Flutter Engine from 0d87b156265c to c08a286d60e9 (3 revisions) (flutter/flutter#119706)

* d27880801 [Re-land] Exposed tooltip longPress (flutter/flutter#118796)

* 254a796bc Revert "Reland "Add --serve-observatory flag to run, attach, and test (#118402)" (#119529)" (flutter/flutter#119729)

* 1573c1296 Marks Mac_android microbenchmarks to be unflaky (flutter/flutter#119727)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidezpl guidezpl guidezpl approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@esouthren @jmagman @guidezpl @liumcse @harperl-lgtm