Skip to content

Commit

Permalink
[web] make sure tests and benchmarks use correct backend - add autode…
Browse files Browse the repository at this point in the history
…tect false (#73047)

* add autodetect false

* fix typo
  • Loading branch information
nturgut committed Dec 28, 2020
1 parent 8f5d037 commit 272b23c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions dev/bots/test.dart
Expand Up @@ -997,6 +997,8 @@ Future<void> _runGalleryE2eWebTest(String buildMode, { bool canvasKit = false })
'--dart-define=FLUTTER_WEB_USE_SKIA=true',
if (!canvasKit)
'--dart-define=FLUTTER_WEB_USE_SKIA=false',
if (!canvasKit)
'--dart-define=FLUTTER_WEB_AUTO_DETECT=false',
'--driver=test_driver/transitions_perf_e2e_test.dart',
'--target=test_driver/transitions_perf_e2e.dart',
'--browser-name=chrome',
Expand Down Expand Up @@ -1151,6 +1153,7 @@ Future<void> _runWebDebugTest(String target, {
'chrome',
'--web-run-headless',
'--dart-define=FLUTTER_WEB_USE_SKIA=false',
'--dart-define=FLUTTER_WEB_AUTO_DETECT=false',
...additionalArguments,
'-t',
target,
Expand Down
2 changes: 2 additions & 0 deletions dev/devicelab/lib/tasks/web_benchmarks.dart
Expand Up @@ -31,6 +31,8 @@ Future<TaskResult> runWebBenchmark({ @required bool useCanvasKit }) async {
'--dart-define=FLUTTER_WEB_ENABLE_PROFILING=true',
if (!useCanvasKit)
'--dart-define=FLUTTER_WEB_USE_SKIA=false',
if (!useCanvasKit)
'--dart-define=FLUTTER_WEB_AUTO_DETECT=false',
if (useCanvasKit)
'--dart-define=FLUTTER_WEB_USE_SKIA=true',
'--profile',
Expand Down

0 comments on commit 272b23c

Please sign in to comment.