Skip to content

Commit

Permalink
remove field override, assign to super field instead (#135165)
Browse files Browse the repository at this point in the history
Removes an ignore about overriding fields. Instead we just assign the value to the original field in the super class.

Related to dart-lang/language#3332 (discovered during investigations into the violation of that lint).
  • Loading branch information
jakemac53 committed Sep 21, 2023
1 parent 528a281 commit daea6e0
Showing 1 changed file with 4 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1335,13 +1335,10 @@ class FakeIOSDevice extends Fake implements IOSDevice {

class TestRunCommandForUsageValues extends RunCommand {
TestRunCommandForUsageValues({
this.devices,
});

@override
// devices is not set within usageValues, so we override the field
// ignore: overridden_fields
List<Device>? devices;
List<Device>? devices,
}) {
this.devices = devices;
}

@override
Future<BuildInfo> getBuildInfo({ BuildMode? forcedBuildMode, File? forcedTargetFile }) async {
Expand Down

0 comments on commit daea6e0

Please sign in to comment.