Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove field override, assign to super field instead #135165

Merged
merged 2 commits into from Sep 21, 2023
Merged

remove field override, assign to super field instead #135165

merged 2 commits into from Sep 21, 2023

Conversation

jakemac53
Copy link
Contributor

@jakemac53 jakemac53 commented Sep 20, 2023 •
edited

Removes an ignore about overriding fields. Instead we just assign the value to the original field in the super class.

Related to dart-lang/language#3332 (discovered during investigations into the violation of that lint).

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 20, 2023
@jakemac53 @christopherfujino
Add space
b573b77 
Co-authored-by: Christopher Fujino <fujino@google.com>
christopherfujino
christopherfujino approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakemac53 jakemac53 added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 21, 2023
@auto-submit auto-submit bot merged commit daea6e0 into flutter:master Sep 21, 2023
119 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
f41bfee 
…er/flutter#135165)
@jakemac53 jakemac53 deleted the dont-override-fields branch September 22, 2023 13:59
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
93f38b9 
…er/flutter#135165)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
49ae68a 
…er/flutter#135165)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
f344b2b 
…er/flutter#135165)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
2312a7b 
…er/flutter#135165)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
3148c87 
…er/flutter#135165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
516bb23 
…er/flutter#135165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
7e10ce2 
…er/flutter#135165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
597eaaf 
…er/flutter#135165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
a234611 
…er/flutter#135165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
9131313 
…er/flutter#135165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
197ffa4 
…er/flutter#135165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
a4a7d96 
…er/flutter#135165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
527d278 
…er/flutter#135165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
f0f2966 
…er/flutter#135165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
0625348 
…er/flutter#135165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
567a0ae 
…er/flutter#135165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
6a8f072 
…er/flutter#135165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
32f7b09 
…er/flutter#135165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
b9941e3 
…er/flutter#135165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
7c321de 
…er/flutter#135165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
bec381a 
…er/flutter#135165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
c158732 
…er/flutter#135165)
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@jakemac53 @Mairramer
remove field override, assign to super field instead (flutter#135165)
bbb2499 
Removes an ignore about overriding fields. Instead we just assign the value to the original field in the super class.

Related to dart-lang/language#3332 (discovered during investigations into the violation of that lint).
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
daea6e00b remove field override, assign to super field instead (flutt…
02642b8 
…er/flutter#135165)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakemac53 @christopherfujino