Skip to content

Commit

Permalink
[flutter_tools] move build_preview_test from commands/permeable to in…
Browse files Browse the repository at this point in the history
…tegration shard (#136912)

Fixes #136907 by moving the test to the tools integration shard, which DOES have VS code installed.
  • Loading branch information
christopherfujino committed Oct 19, 2023
1 parent 27cf404 commit fd16046
Show file tree
Hide file tree
Showing 3 changed files with 55 additions and 68 deletions.
6 changes: 2 additions & 4 deletions packages/flutter_tools/lib/src/commands/build_preview.dart
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,12 @@ import 'build.dart';
class BuildPreviewCommand extends BuildSubCommand {
BuildPreviewCommand({
required super.logger,
required bool verboseHelp,
required super.verboseHelp,
required this.fs,
required this.flutterRoot,
required this.processUtils,
required this.artifacts,
}) : super(verboseHelp: verboseHelp) {
addCommonDesktopBuildOptions(verboseHelp: verboseHelp);
}
});

@override
final String name = '_preview';
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'dart:io';

import 'package:file_testing/file_testing.dart';
import 'package:flutter_tools/src/base/file_system.dart';
import 'package:flutter_tools/src/base/platform.dart';
import 'package:flutter_tools/src/cache.dart';

import '../src/common.dart';
import '../src/context.dart';
import 'test_utils.dart';

void main() {
Cache.disableLocking();

late Directory tempDir;
final FileSystem fs = LocalFileSystemBlockingSetCurrentDirectory();
final String flutterBin = fs.path.join(getFlutterRoot(), 'bin', 'flutter');
final File previewBin = fs
.directory(getFlutterRoot())
.childDirectory('bin')
.childDirectory('cache')
.childDirectory('artifacts')
.childDirectory('flutter_preview')
.childFile('flutter_preview.exe');

setUp(() {
tempDir = fs.systemTempDirectory.createTempSync('flutter_tools_preview_integration_test.');
});

tearDown(() {
tryToDelete(tempDir);
tryToDelete(previewBin);
});

testUsingContext('flutter build _preview creates preview device', () async {
final ProcessResult result = await processManager.run(<String>[
flutterBin,
'build',
'_preview',
'--verbose',
]);

expect(result, const ProcessResultMatcher());
expect(
previewBin,
exists,
);
}, skip: !const LocalPlatform().isWindows); // [intended] Flutter Preview only supported on Windows currently
}

0 comments on commit fd16046

Please sign in to comment.