Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows tool_tests_commands flakes on missing Visual Studio toolchain #136907

Closed
christopherfujino opened this issue Oct 19, 2023 · 1 comment · Fixed by #136912
Closed

Windows tool_tests_commands flakes on missing Visual Studio toolchain #136907

christopherfujino opened this issue Oct 19, 2023 · 1 comment · Fixed by #136912
Assignees

Comments

@christopherfujino
Copy link
Member

I introduced a command test that does a real windows build, but the commands shard doesn't specify a dependency on VS. This should be moved to the integration shard.

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8766840633390392737/+/u/run_test.dart_for_tool_tests_shard_and_subshard_commands/test_stdout

01:24 +641: test/commands.shard\permeable\build_preview_test.dart: flutter build _preview creates preview device
Exception: Unable to find suitable Visual Studio toolchain. Please run `flutter doctor` for more details.
#0      throwToolExit (package:flutter_tools/src/base/common.dart:10:3)
#1      buildWindows (package:flutter_tools/src/windows/build_windows.dart:88:5)
@christopherfujino christopherfujino self-assigned this Oct 19, 2023
auto-submit bot pushed a commit that referenced this issue Oct 19, 2023
…tegration shard (#136912)

Fixes #136907 by moving the test to the tools integration shard, which DOES have VS code installed.
Copy link

github-actions bot commented Nov 2, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant