Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go_router_builder] should integration tests run in CI? #102799

Closed
ditman opened this issue Apr 29, 2022 · 3 comments
Closed

[go_router_builder] should integration tests run in CI? #102799

ditman opened this issue Apr 29, 2022 · 3 comments
Assignees
Labels
a: tests "flutter test", flutter_test, or one of our tests p: go_router_builder The go_router_builder package package flutter/packages repository. See also p: labels.

Comments

@ditman
Copy link
Member

ditman commented Apr 29, 2022

After some comments in an unrelated PR, I've been trying to find where these tests are running in our testing infrastructure, but couldn't find anything after peeking at a bunch of logs:

  • ios-build+platform-test skipped (1, 2)
  • ios-custom_package_tests skipped (1, 2)
  • test only runs these, as expected (1)

I didn't look much further, so I might have missed the exact log where those tests are running; but it seems to me that the integration tests present in go_router_builder example aren't running in CI. Should they?

(This is maybe because of the odd directory structure of the example app that is different from what is expected by the tooling?)

@ditman ditman added a: tests "flutter test", flutter_test, or one of our tests plugin team-infra Owned by Infrastructure team p: go_router_builder The go_router_builder package and removed team-infra Owned by Infrastructure team labels Apr 29, 2022
@chunhtai chunhtai self-assigned this Apr 29, 2022
@chunhtai
Copy link
Contributor

The integration test failed when running locally, will need to fix that first

kevmoo added a commit to flutter/packages that referenced this issue Apr 29, 2022
@ditman
Copy link
Member Author

ditman commented Apr 29, 2022

I'm going to deduplicate this in favor of: #102845

@ditman ditman closed this as completed Apr 29, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: tests "flutter test", flutter_test, or one of our tests p: go_router_builder The go_router_builder package package flutter/packages repository. See also p: labels.
Projects
None yet
Development

No branches or pull requests

2 participants