Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-pin url_launcher_android in flutter/flutter #111304

Closed
christopherfujino opened this issue Sep 9, 2022 · 11 comments · Fixed by #134958
Closed

Un-pin url_launcher_android in flutter/flutter #111304

christopherfujino opened this issue Sep 9, 2022 · 11 comments · Fixed by #134958
Assignees
Labels
a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. P1 High-priority issues at the top of the work list team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-android Owned by Android platform team triaged-android Triaged by Android platform team

Comments

@christopherfujino
Copy link
Member

christopherfujino commented Sep 9, 2022

PR with broken build tests: https://github.com/flutter/flutter/pull/111197/files#diff-9aeff568c87b1d587222c343afb84ef72fc07e0692d50ecb3de670e5606f9505R46

I believe it is this change: flutter/plugins#6194. Note, something similar happened in #109397 with path_provider_android, and what happened was that the change was reverted upstream and a new version released.

I imagine we will eventually need to find a way to get the migrated versions of these plugins passing flutter/flutter CI.

@christopherfujino christopherfujino added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. plugin labels Sep 9, 2022
@christopherfujino
Copy link
Member Author

I will work around this by pinning url_launcher_android so that the pub autoroller can continue

@christopherfujino
Copy link
Member Author

cc @GaryQian and @stuartmorgan

@GaryQian
Copy link
Contributor

GaryQian commented Sep 9, 2022

These gradle bumps that skip many version have been causing us pain elsewhere as well. It'll take a slow process to eventually get everything upgraded and passing. We should probably just revert for now and hold off on dependabot gradle bumps

@stuartmorgan
Copy link
Contributor

Why are we reverting public packages instead of just pinning in the CI?

@stuartmorgan
Copy link
Contributor

These gradle bumps that skip many version have been causing us pain elsewhere as well. It'll take a slow process to eventually get everything upgraded and passing.

If we keep reverting because of flutter/flutter CI, how will we make progress on this?

Unless we think this will affect clients other that flutter/flutter CI it seems like pinning allows us to make progress for everything else with minimal impact.

@christopherfujino
Copy link
Member Author

These gradle bumps that skip many version have been causing us pain elsewhere as well. It'll take a slow process to eventually get everything upgraded and passing.

If we keep reverting because of flutter/flutter CI, how will we make progress on this?

Unless we think this will affect clients other that flutter/flutter CI it seems like pinning allows us to make progress for everything else with minimal impact.

So I am pinning: #111309. I'm ok with not reverting provided that work on eventually landing the newer versions with the new gradle is prioritized. Eventually a pinned dependency will hold back other packages with shared transitive dependencies from being upgraded.

@stuartmorgan
Copy link
Contributor

Have we root-caused either this or the previous case yet to understand what exactly broke and why? We should definitely prioritize that to make sure we understand client effects and paths forward.

@stuartmorgan stuartmorgan added the P1 High-priority issues at the top of the work list label Sep 15, 2022
@stuartmorgan
Copy link
Contributor

@GaryQian Could you take a look at what exactly the issue was, so we know what we need to do before making future plugin gradle version changes?

@stuartmorgan stuartmorgan changed the title Newest url_launcher_android release breaks flutter/flutter build tests Un-pin url_launcher_android in flutter/flutter Jan 21, 2023
@stuartmorgan
Copy link
Contributor

Re-titling and re-labeling since at this point it looks this is an issue with updating flutter/flutter example projects rather than a problem with the plugin itself.

@stuartmorgan stuartmorgan added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. and removed plugin labels Jan 21, 2023
@flutter-triage-bot flutter-triage-bot bot added team-framework Owned by Framework team triaged-framework Triaged by Framework team labels Jul 8, 2023
@flutter-triage-bot flutter-triage-bot bot removed the triaged-framework Triaged by Framework team label Aug 26, 2023
@flutter-triage-bot
Copy link

This issue is marked P1 but has had no recent status updates.

The P1 label indicates high-priority issues that are at the top of the work list. This is the highest priority level a bug can have if it isn't affecting a top-tier customer or breaking the build. Bugs marked P1 are generally actively being worked on unless the assignee is dealing with a P0 bug (or another P1 bug). Issues at this level should be resolved in a matter of months and should have monthly updates on GitHub.

Please consider where this bug really falls in our current priorities, and label it or assign it accordingly. This allows people to have a clearer picture of what work is actually planned. Thanks!

@christopherfujino christopherfujino added team-android Owned by Android platform team and removed team-framework Owned by Framework team P1 High-priority issues at the top of the work list labels Aug 28, 2023
@camsim99 camsim99 added P1 High-priority issues at the top of the work list triaged-android Triaged by Android platform team labels Sep 7, 2023
auto-submit bot pushed a commit that referenced this issue Sep 20, 2023
More up to date version of #133786.

Fixes #111304
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2023
Mairramer pushed a commit to Mairramer/flutter that referenced this issue Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. P1 High-priority issues at the top of the work list team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-android Owned by Android platform team triaged-android Triaged by Android platform team
Projects
None yet
5 participants