Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin url_launcher_android, and roll pub packages #133786

Closed
wants to merge 10 commits into from
Closed

Unpin url_launcher_android, and roll pub packages #133786

wants to merge 10 commits into from

Conversation

gmackall
Copy link
Member

@gmackall gmackall commented Aug 31, 2023 •
edited

Unpins the version of url_launcher_android that was pinned in #111309.

Also

  1. rolls pub packages with flutter update-packages --force-upgrade, for the unpinning to take effect,
  2. and regenerates the lockfiles for the flutter_gallery integration test with ./gradlew :generateLockfiles from dev/integration_tests/flutter_gallery/android.

Fixes #111304

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 31, 2023
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Aug 31, 2023
@gmackall gmackall changed the title Unpin url_launcher_android Unpin url_launcher_android, and roll pub packages Aug 31, 2023
@gmackall gmackall marked this pull request as ready for review August 31, 2023 20:56
christopherfujino
christopherfujino approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, you're my hero! LGTM

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2023
gmackall
gmackall commented Aug 31, 2023
View reviewed changes
dev/integration_tests/flutter_gallery/pubspec.yaml Outdated
# This is listed as direct so it can be manually pinned
url_launcher_android: 6.0.17
cupertino_icons: 1.0.5
url_launcher_android: 6.0.39
Copy link
Member Author

@gmackall gmackall Aug 31, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This got updated correctly, but I'll push another commit after deleting it and re-running flutter update-packages --force-upgrade so that it is properly marked with THIS LINE IS AUTOGENERATED (and remove comment saying its manually pinned)

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 31, 2023

auto label is removed for flutter/flutter/133786, due to - The status or check suite Mac build_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gmackall gmackall added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Aug 31, 2023
@gmackall
Copy link
Member Author

Overriding google testing status, per https://discordapp.com/channels/608014603317936148/608021351567065092/1146933282269823006

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 1, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 1, 2023

auto label is removed for flutter/flutter/133786, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gmackall
Copy link
Member Author

gmackall commented Sep 1, 2023

Google testing still seems to be blocking this, despite #133814 being resolved. I'm going to try to kick it off once more

@gmackall gmackall mentioned this pull request Sep 5, 2023
Closed
8 tasks
@gmackall
Copy link
Member Author

gmackall commented Sep 5, 2023 •
edited

Unfortunately it looks like the google testing failures are not related to #133814 (they persist in a new PR made this morning, created with the same steps), so I'll need to dig into the failures to see whats going on.

It's a good thing the Google testing override didn't work 😅

@christopherfujino
Copy link
Member

In the FRoB dashboard, it claims that I set the GitHub check to passing.

@goderbauer
Copy link
Member

(triage) Can you resolve the merge conflict and rebase this to see if we can get google testing to pass now?

@gmackall gmackall closed this Sep 12, 2023
@gmackall gmackall reopened this Sep 12, 2023
@github-actions github-actions bot added the a: internationalization Supporting other languages or locales. (aka i18n) label Sep 12, 2023
@gmackall
Copy link
Member Author

Updated by doing the same process as the description.

I'm also planning on running through the Google testing tomorrow with @reidbaker. Should have noted that on the PR, sorry!

@gmackall gmackall mentioned this pull request Sep 19, 2023
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request Sep 20, 2023
@gmackall
Unpin url launcher (remake) (#134958)
f4b5fc1 
More up to date version of #133786.

Fixes #111304
@gmackall
Copy link
Member Author

Closing as done in #134958

@gmackall gmackall closed this Sep 20, 2023
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@gmackall @Mairramer
Unpin url launcher (remake) (flutter#134958)
bab5fd5 
More up to date version of flutter#133786.

Fixes flutter#111304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Un-pin url_launcher_android in flutter/flutter
3 participants
@gmackall @christopherfujino @goderbauer