Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go_router]: implemented helpers for ShellRoute #2730

Merged
merged 31 commits into from Feb 23, 2023
Merged

[go_router]: implemented helpers for ShellRoute #2730

merged 31 commits into from Feb 23, 2023

Conversation

hawkkiller
Copy link
Contributor

@hawkkiller hawkkiller commented Oct 23, 2022 •
edited

PR for helpers and annotations in go_router for the shell route support and a bit of refactoring.

flutter/flutter#111909

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@hawkkiller
Copy link
Contributor Author

@chunhtai Hi! A separate PR is created for go_router.

@hawkkiller
Copy link
Contributor Author

@chunhtai up

chunhtai
chunhtai reviewed Nov 11, 2022
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest LGTM

packages/go_router/CHANGELOG.md Outdated Show resolved Hide resolved
packages/go_router/lib/src/route_data.dart Outdated Show resolved Hide resolved
@chunhtai
Copy link
Contributor

(triage) It looks like the build is failing and there is merge conflict

@chunhtai
Copy link
Contributor

chunhtai commented Dec 1, 2022

(triage) hi @hawkkiller, are you still planning on coming back to this pr?

@hawkkiller
Copy link
Contributor Author

hawkkiller commented Dec 2, 2022 •
edited

@chunhtai hi! What's left here? Only ci checks and conflicts?

@hawkkiller
Copy link
Contributor Author

@chunhtai hi again. Fixed tests and changed code a bit. Now each route has navigatorKey, not the abstract only.

@kostadin-damyanov-prime
Copy link

Hi. Is there any update on this?

johnpryan
johnpryan requested changes Feb 22, 2023
View reviewed changes
packages/go_router/lib/src/route_data.dart Outdated Show resolved Hide resolved
packages/go_router/test/route_data_test.dart Outdated Show resolved Hide resolved
@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 22, 2023
@johnpryan johnpryan removed needs tests autosubmit Merge PR when tree becomes green via auto submit App labels Feb 22, 2023
@johnpryan
Copy link
Contributor

I'm going to export ShellRouteData too.

@johnpryan johnpryan added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 22, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 22, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 22, 2023

auto label is removed for flutter/packages, pr: 2730, due to - The status or check suite analyze CHANNEL:master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@johnpryan johnpryan mentioned this pull request Feb 22, 2023
Merged
11 tasks
@johnpryan johnpryan added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 22, 2023
This was referenced Feb 22, 2023
Closed
Closed
@johnpryan
Copy link
Contributor

@stuartmorgan @ditman can you help us figure out why CI is failing?

@ditman
Copy link
Member

ditman commented Feb 22, 2023

@stuartmorgan @ditman can you help us figure out why CI is failing?

@johnpryan "submit-queue" is the check that asserts that whatever is at the tip of flutter/packages main branch is passing all post-submit tests.

It looks red now, because flutter/packages main is undergoing testing (here), but once that finishes correctly, it'll turn green in this PR as well.

@auto-submit auto-submit bot merged commit 5834b4c into flutter:main Feb 23, 2023
@ditman ditman mentioned this pull request Feb 23, 2023
Closed
ditman added a commit to ditman/flutter-flutter that referenced this pull request Feb 24, 2023
@ditman
Roll Packages from 6c04c74 to ad48ee5 (28 revisions)
e3abb78 
* ad48ee5 [go_router] Fix some broken links in doc (flutter/packages#3288)
* 58ac45e [go_router_builder] Add support for Iterable, List  and Set to TypedGoRoute (flutter/packages#2679)
* 0edae25 Export super types in route_data.dart library (flutter/packages#3286)
* 8ad3fde [go_router] Add `GoRouter.maybeOf` (flutter/packages#3216)
* 13ee644 [flutter_migrate] Skip slow tests (flutter/packages#3270)
* 3cc754a Update .gitignore with missing values from flutter/plugins (flutter/packages#3265)
* c0f0a22 [ci] Re-enable pathified unit tests (flutter/packages#3268)
* 5834b4c [go_router]: implemented helpers for ShellRoute (flutter/packages#2730)
* af5906b [extension_gsi] Update extension to support gsi 5 and 6. (flutter/packages#3235)
* 195f4e8 Merge in plugin README and CONTRIBUTING (flutter/packages#3252)
* fab47af [go_router] Disable logging in tests (flutter/packages#3263)
* 25f0f70 [various] Update flutter/plugins links (flutter/packages#3256)
* 2e16733 Merge flutter/plugins (flutter/packages#3233)
* 324a7f2 Exclude more tests on Windows
* 334b58e Adjust test configs
* 69e6dac [go_router_builder] Generate replace method in RouteExtension (flutter/packages#2838)
* 193e454 Merge repository metadata
* 18715d7 Merge remote-tracking branch 'plugins-packages/main' into merge-flutter-plugins
* f2d802d Roll Flutter from ae8d051 to 7175de4 (4 revisions) (flutter/packages#3232)
* 6f1b1e8 Roll Flutter from 33e4d21 to ae8d051 (6 revisions) (flutter/packages#3229)
* a162a98 Roll Flutter from 0be7c3f to 33e4d21 (5 revisions) (flutter/packages#3227)
* ab5a8c0 [tool] Allow importing packages with NEXT (flutter/packages#3215)
* ce9c61b Roll Flutter from 170539f to 0be7c3f (38 revisions) (flutter/packages#3225)
* 9747469 Fix deprecation message for GoRouterState.namedLocation (flutter/packages#3092)
* 6e4431f [go_router] Bump example `compileSdkVersion` and `package_info_plus` dependency version (flutter/packages#3219)
* 925bea8 [pigeon] Validate generated files in CI (flutter/packages#3224)
* 3094867 Move iOS Swift unit tests back to Cirrus (flutter/packages#3221)
* 763d025 [pigeon] Eliminate some of the test pigeons (flutter/packages#3213)
@ditman ditman mentioned this pull request Feb 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnpryan johnpryan johnpryan approved these changes

@kostadin-damyanov-prime kostadin-damyanov-prime kostadin-damyanov-prime left review comments

@chunhtai chunhtai chunhtai approved these changes

@hangyujin hangyujin Awaiting requested review from hangyujin

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: go_router
Projects
None yet
Milestone
No milestone
7 participants
@hawkkiller @chunhtai @ycherniavskyi @stuartmorgan @johnpryan @kostadin-damyanov-prime @ditman