Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform preliminary setups on iphone11 for deployment in devicelab #117237

Closed
yusuf-goog opened this issue Dec 16, 2022 · 22 comments
Closed

Perform preliminary setups on iphone11 for deployment in devicelab #117237

yusuf-goog opened this issue Dec 16, 2022 · 22 comments
Assignees
@kentnguyen99
Labels
team-infra Owned by Infrastructure team

Comments

@yusuf-goog
Copy link
Contributor

Please follow instrunctions sent via email to setup iphone11 devices for install in the devicelab.

While setting up, note device_id and label which hostname each will be assigned to, so that we can update apple provisioning profiles.
@yusuf-goog yusuf-goog added the team-infra Owned by Infrastructure team label Dec 16, 2022
@yusuf-goog
Copy link
Contributor Author

cc @jmagman @godofredoc

@yusuf-goog
Copy link
Contributor Author

Provided instructions from g3doc to Kent on ios device setup.
Debuggged new device provisioning issues that came up. (Requires use of mac machine to setup new devices).
Setup one iphone11 with ios16 and swapped it in on mac-44.
Created CL with provisioning profile update for new device.

Gave Kent a new mac mini from lab inventory to use to setup new ios devices.

@yusuf-goog
Copy link
Contributor Author

@jmagman There are 2 references to ios-15 devices in flutter (https://github.com/flutter/flutter/blob/master/.ci.yaml#L134). Do we need to remove that requirement or update to 16, now that we are starting to upgrade ios devices?

@jmagman
Copy link
Member

jmagman commented Dec 21, 2022

I suggest

  1. Smoke test to validate the tests all pass on the new iPhone 11/ iOS 16 devices via led runs, as we did a few months ago.
  2. Update half the fleet to the new devices in all pools
  3. Update the staging config IOS_VERSION
    https://flutter.googlesource.com/infra/+/refs/heads/main/config/devicelab_staging_config.star#22
  4. Let that run in staging for at least a commit or two to validate tests are passing in staging.
  5. Swap flutter/flutter .ci.yaml

    flutter/.ci.yaml

    Line 134 in 2a50236

    device_os: iOS-15

    flutter/.ci.yaml

    Line 146 in 2a50236

    device_os: iOS-15
  6. Update the rest of the infra fallback values
    https://flutter.googlesource.com/infra/+/refs/heads/main/config/flutter_config.star#108
    https://flutter.googlesource.com/infra/+/refs/heads/main/config/iostools_config.star#61
  7. Update the remaining devices in the fleet.

@jmagman jmagman mentioned this issue Dec 21, 2022
Closed
@yusuf-goog
Copy link
Contributor Author

iphone11 has been deployed to mac-44 and is ready to process jobs.

@yusuf-goog
Copy link
Contributor Author

yusuf-goog commented Dec 21, 2022 •
edited
Loading

Next steps:

  • Smoke test to validate the tests all pass on the new iPhone 11/ iOS 16 devices via led runs, as we did a few months ago.

Once @jmagman has a chance to validate the mac-44 setup, we will then:

  • Run setup steps on 3 more iphone11 devices
  • Note their device ids, and select 3 hosts from the staging pool to swap them out with
  • Update provisioning profiles and deploy
  • Swap out the iphones on the 3 selected hosts
  • Monitor to see everything is up and running as expected

@yusuf-goog
Copy link
Contributor Author

Trying to run some builds using led on mac-44, but getting errors:

led get-builder 'luci.flutter.prod:Mac_ios hello_world_ios__compile' | led edit -d id=flutter-devicelab-mac-44 | led edit -d pool=luci.flutter.prod | led edit -d device_os=iOS-16 | led edit -d cpu=arm64 | led launch -modernize

The fix is to save the output of led get-builder 'luci.flutter.prod:Mac_ios hello_world_ios__compile' and remove the line cleanup_cache:true, before piping it into the rest of the command.

@yusuf-goog
Copy link
Contributor Author

"The device may be running a version of iOS (16.2 20C65) that is not supported by this version of Xcode". @jmagman is going to create a new xcode cipd package, and we will try to run the tests again.

All devices are being setup now, so they should all be at 16.2 at time of deployment.

@jmagman
Copy link
Member

jmagman commented Dec 22, 2022

Filed #117505.

@jmagman
Copy link
Member

jmagman commented Dec 22, 2022

@yusuf-goog what specifically is this issue tracking vs #111131?

@yusuf-goog
Copy link
Contributor Author

This issue is meant for our new lab tech. His account has not been approved yet, so he's not on this.

@kentnguyen99
Copy link

Next step to configure & setup new iPhones 11 and upgrade iOS to version 16.2.

@jmagman
Copy link
Member

jmagman commented Jan 10, 2023

#117505 has merged. Please keep the iPhone 6s and cables so we can use them as test devices in the future in go/flutter-device-library (@yusuf-goog to be deposited on the test device pile desk in 1808 🙂 )

@yusuf-goog
Copy link
Contributor Author

@jmagman Testing results are looking good, with no apparent failures. We are ready to continue to step 2. listed above.

We expect to start the swap out on Thursday morning PST.

@yusuf-goog
Copy link
Contributor Author

We will start with the following swaps:

Prod: mac-43, 42, 41, 30, 29, 28.
mac-44 already has an iphone11.

Staging: mac-5, 7, 13.
mac-4 already has an iphone11.

Try: mac-1, 12

Once verified, we will continue upgrade of remaining devices in the pools.

@yusuf-goog
Copy link
Contributor Author

provisioning profile CL: go/tircl/651552

@yusuf-goog
Copy link
Contributor Author

We installed one iphone11 device on mac-43 to validate provisioning profile changes and our install procedure are correct. It installed correctly and was able to successfully run a build.

yusuf-goog added a commit to yusuf-goog/flutter that referenced this issue Jan 19, 2023
@yusuf-goog
Switching over from iOS-15 to iOS-16 in .ci.yaml.
36b5472 
This will run tests on new iphone11 devicelab devices
which are running iOS-16.

Bug:flutter#117237
@yusuf-goog yusuf-goog mentioned this issue Jan 19, 2023
Merged
8 tasks
@yusuf-goog
Copy link
Contributor Author

First phase of iphone11 swaps are complete.
Submitting change to staging config: https://flutter-review.git.corp.google.com/c/infra/+/38153

@yusuf-goog
Copy link
Contributor Author

https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_ios_staging%20test_drone/13/overview staging test ran on new ios-16 device successfully.

auto-submit bot pushed a commit that referenced this issue Jan 19, 2023
@yusuf-goog
Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807)
9b5ea30 
This will run tests on new iphone11 devicelab devices
which are running iOS-16.

Bug:#117237
This was referenced Jan 19, 2023
Closed
Merged
Closed
This was referenced Jan 19, 2023
Closed
Closed
This was referenced Jan 19, 2023
Closed
Closed
@yusuf-goog
Copy link
Contributor Author

CL for step 6.: https://flutter-review.git.corp.google.com/c/infra/+/38129

XilaiZhang pushed a commit to XilaiZhang/flutter that referenced this issue Jan 21, 2023
@yusuf-goog @XilaiZhang
Switching over from iOS-15 to iOS-16 in .ci.yaml. (flutter#118807)
f3a8ef3 
This will run tests on new iphone11 devicelab devices
which are running iOS-16.

Bug:flutter#117237
@XilaiZhang XilaiZhang mentioned this issue Jan 21, 2023
Merged
XilaiZhang added a commit that referenced this issue Feb 1, 2023
@XilaiZhang @yusuf-goog
Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (#118963)
9271eeb 
This will run tests on new iphone11 devicelab devices
which are running iOS-16.

Bug:#117237

Co-authored-by: yusuf-goog <91688203+yusuf-goog@users.noreply.github.com>
@yusuf-goog
Copy link
Contributor Author

All iphone11 are deployed to the lab.

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kentnguyen99 kentnguyen99

Labels
team-infra Owned by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmagman @yusuf-goog @kentnguyen99