Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release + cherry-pick] Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) #118963

Merged
merged 3 commits into from
Feb 1, 2023
Merged

[release + cherry-pick] Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) #118963

merged 3 commits into from
Feb 1, 2023

Conversation

XilaiZhang
Copy link
Contributor

fix post submit failures on beta hotfix release

This will run tests on new iphone11 devicelab devices which are running iOS-16.

Bug:#117237

@yusuf-goog @XilaiZhang
Switching over from iOS-15 to iOS-16 in .ci.yaml. (flutter#118807)
f3a8ef3 
This will run tests on new iphone11 devicelab devices
which are running iOS-16.

Bug:flutter#117237
@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@itsjustkevin itsjustkevin self-requested a review January 21, 2023 22:40
CaseyHillers
CaseyHillers suggested changes Jan 21, 2023
View reviewed changes
Copy link
Contributor

@CaseyHillers CaseyHillers left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not land until we can discuss on Monday.

We should not change the devices that are being tested in release branches. Instead, we should look at reverting the infra changes to make it compatible for the release.

@XilaiZhang
Copy link
Contributor Author

Do not land until we can discuss on Monday.

We should change the devices that are being tested in release branches. Instead, we should look at reverting the infra changes to make it compatible for the release.

Thanks for the instructions Casey!

@CaseyHillers
Copy link
Contributor

@XilaiZhang can you link to the GitHub issue here with the context why this change is needed?

@godofredoc
Copy link
Contributor

@XilaiZhang can you link to the GitHub issue here with the context why this change is needed?

\cc @yusuf-goog @jmagman

@CaseyHillers
Copy link
Contributor

I filed #119014 as a tracking bug to ensure we're aligned on what change is needed.

@yusuf-goog yusuf-goog mentioned this pull request Jan 23, 2023
Closed
@goderbauer goderbauer added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-infra Owned by Infrastructure team labels Jan 23, 2023
@CaseyHillers CaseyHillers mentioned this pull request Jan 26, 2023
Closed
CaseyHillers
CaseyHillers approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@CaseyHillers CaseyHillers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CP request was formerly filed in #119029, and the necessary approvals have been added there.

@XilaiZhang XilaiZhang mentioned this pull request Jan 31, 2023
Merged
@XilaiZhang XilaiZhang merged commit 9271eeb into flutter:flutter-3.7-candidate.1 Feb 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2023
@engine-flutter-autoroll
9271eeba1 Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (…
721e018 
…flutter/flutter#118963)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 2, 2023
@engine-flutter-autoroll
9271eeba1 Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (…
5e4379b 
…flutter/flutter#118963)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 2, 2023
@engine-flutter-autoroll
Roll Flutter (stable) from b06b8b271095 to 7048ed95a5ad (5 revisions) (…
9f8c807 
…#3143)

* 7999584b9 [release] use current branch as opposed to master (flutter/flutter#119648)

* 9271eeba1 Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (flutter/flutter#118963)

* c96f14ad3 Support safe area and scrolling in the NavigationDrawer (#116995) (flutter/flutter#119555)

* ff6e9d4fa CP: Throw error when plural case had undefined behavior (#116622) (flutter/flutter#119384)

* 7048ed95a Update Engine revision to 800594f1f4a6674010a6f1603c07a919b4d7ebd7 for stable release 3.7.1 (flutter/flutter#119687)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 2, 2023
@engine-flutter-autoroll
9271eeba1 Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (…
a377d42 
…flutter/flutter#118963)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 3, 2023
@engine-flutter-autoroll
9271eeba1 Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (…
d57e910 
…flutter/flutter#118963)
stuartmorgan pushed a commit to flutter/plugins that referenced this pull request Feb 3, 2023
@engine-flutter-autoroll
Roll Flutter (stable) from b06b8b271095 to 7048ed95a5ad (5 revisions) (…
bde2ff0 
…#7091)

* 7999584b9 [release] use current branch as opposed to master (flutter/flutter#119648)

* 9271eeba1 Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (flutter/flutter#118963)

* c96f14ad3 Support safe area and scrolling in the NavigationDrawer (#116995) (flutter/flutter#119555)

* ff6e9d4fa CP: Throw error when plural case had undefined behavior (#116622) (flutter/flutter#119384)

* 7048ed95a Update Engine revision to 800594f1f4a6674010a6f1603c07a919b4d7ebd7 for stable release 3.7.1 (flutter/flutter#119687)
Maatteogekko pushed a commit to Maatteogekko/packages that referenced this pull request Feb 4, 2023
@engine-flutter-autoroll @Maatteogekko
Roll Flutter (stable) from b06b8b271095 to 7048ed95a5ad (5 revisions) (…
8318dca 
…flutter#3143)

* 7999584b9 [release] use current branch as opposed to master (flutter/flutter#119648)

* 9271eeba1 Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (flutter/flutter#118963)

* c96f14ad3 Support safe area and scrolling in the NavigationDrawer (#116995) (flutter/flutter#119555)

* ff6e9d4fa CP: Throw error when plural case had undefined behavior (#116622) (flutter/flutter#119384)

* 7048ed95a Update Engine revision to 800594f1f4a6674010a6f1603c07a919b4d7ebd7 for stable release 3.7.1 (flutter/flutter#119687)
@XilaiZhang XilaiZhang deleted the flutter-3.7-candidate.1 branch February 10, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyHillers CaseyHillers CaseyHillers approved these changes

@itsjustkevin itsjustkevin itsjustkevin approved these changes

@yusuf-goog yusuf-goog yusuf-goog approved these changes

@keyonghan keyonghan Awaiting requested review from keyonghan

@godofredoc godofredoc Awaiting requested review from godofredoc

Assignees
No one assigned
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-infra Owned by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@XilaiZhang @CaseyHillers @godofredoc @itsjustkevin @yusuf-goog @goderbauer